infra: Automatically publish to PyPi #148
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| name: Publish distribution to PyPI | ||
|
|
||
| on: | ||
| release: | ||
| types: [published] | ||
|
|
||
| jobs: | ||
| build-and-publish: | ||
| name: Build and publish distribution to PyPi | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@main | ||
| - name: Set up Python 3.7 | ||
| uses: actions/setup-python@v1 | ||
| with: | ||
| python-version: 3.7 | ||
|
There was a problem hiding this comment. This is still publishing to PyPI for 3.7 and 3.8? There was a problem hiding this comment. It'll still be compatible with 3.8; I haven't really seen packages on PyPi with multiple tarballs and wheels for a single version |
||
| - name: Install wheel | ||
| run: python -m pip install --user --upgrade wheel | ||
| - name: Install twine | ||
| run: python -m pip install --user --upgrade twine | ||
| - name: Build a binary wheel and a source tarball | ||
| run: python setup.py sdist bdist_wheel | ||
| - name: Publish distribution to PyPI | ||
| uses: pypa/gh-action-pypi-publish@master | ||
| with: | ||
| password: ${{ secrets.pypi_token }} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, this is every time there's a new release in https://github.com/aws/amazon-braket-sdk-python/releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. How do we know it's successful? Just check the PyPI website, or is there a notification/logs we can view?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking PyPi is the end-all-be-all, but there's also the repo's "Actions" tab that will give a history of every run. I think you can configure your account's notifications for Actions too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to run integ/unit tests before the PyPI release? For example, instead of having it in Github Actions, and instead triggered by webhook in codebuild?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, perhaps this can help with running unit/integ tests: https://github.com/aws-actions/aws-codebuild-run-build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, releases are in fact automatic; as soon as the version number is bumped, a release is automatically created. The main future change would be automatic version bumping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the release notes for an automatic update? Doesn't that have to be manually entered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the way it currently stands, the release notes would have to be post-edited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, from the point of view of manual releases, I think once we have integ tests running as part of the PR builds we should be good.