infra: Automatically publish to PyPi #148
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| - name: Set up Python 3.7 | ||
| uses: actions/setup-python@v1 | ||
| with: | ||
| python-version: 3.7 |
There was a problem hiding this comment.
This is still publishing to PyPI for 3.7 and 3.8?
There was a problem hiding this comment.
It'll still be compatible with 3.8; I haven't really seen packages on PyPi with multiple tarballs and wheels for a single version
| name: Publish distribution to PyPI | ||
|
|
||
| on: | ||
| release: |
There was a problem hiding this comment.
Just to clarify, this is every time there's a new release in https://github.com/aws/amazon-braket-sdk-python/releases?
There was a problem hiding this comment.
Thanks. How do we know it's successful? Just check the PyPI website, or is there a notification/logs we can view?
There was a problem hiding this comment.
Checking PyPi is the end-all-be-all, but there's also the repo's "Actions" tab that will give a history of every run. I think you can configure your account's notifications for Actions too.
There was a problem hiding this comment.
Is it possible to run integ/unit tests before the PyPI release? For example, instead of having it in Github Actions, and instead triggered by webhook in codebuild?
There was a problem hiding this comment.
Also, perhaps this can help with running unit/integ tests: https://github.com/aws-actions/aws-codebuild-run-build
There was a problem hiding this comment.
Right, releases are in fact automatic; as soon as the version number is bumped, a release is automatically created. The main future change would be automatic version bumping.
There was a problem hiding this comment.
What about the release notes for an automatic update? Doesn't that have to be manually entered?
There was a problem hiding this comment.
Yeah, the way it currently stands, the release notes would have to be post-edited.
There was a problem hiding this comment.
OK, from the point of view of manual releases, I think once we have integ tests running as part of the PR builds we should be good.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
* docs: Add docs for job examples * address comments
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.