Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group extensions under the 'packages' folder #1

Closed
wants to merge 1 commit into from

Conversation

alvsan09
Copy link
Owner

This will follow a consistent folder structure as per default
'lerna' and 'theia'.

It will additionally prevent the top level project from growing as
more extensions get added.

Fixes: eclipse-theia#87

Signed-off-by: Alvaro Sanchez-Leon [email protected]

What it does

How to test

Review checklist

Reminder for reviewers

This will follow a consistent folder structure as per default
'lerna' and 'theia'.

It will additionally prevent the top level project from growing as
more extensions get added.

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
Copy link

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes did not remove the old extension folders...

See: https://github.com/eclipse-theia/theia-blueprint/tree/f9f70abaa6cee5c9b40c3b4c9703865c6e549fb1

Since I already worked on changing the layout when working on the browser version of Blueprint, I opened an alternative PR.

See eclipse-theia#88

@alvsan09
Copy link
Owner Author

Your changes did not remove the old extension folders...

See: https://github.com/eclipse-theia/theia-blueprint/tree/f9f70abaa6cee5c9b40c3b4c9703865c6e549fb1

Since I already worked on changing the layout when working on the browser version of Blueprint, I opened an alternative PR.

See eclipse-theia#88

Yeap, the old files were removed on my local repo. although I missed them in the commit,
That's OK, I will close this one to consider PR eclipse-theia#88 instead.

@alvsan09 alvsan09 closed this Apr 28, 2021
@alvsan09 alvsan09 deleted the move-extensions-to-packages branch April 28, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensions are not grouped under a folder
2 participants