Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions are not grouped under a folder #87

Closed
alvsan09 opened this issue Apr 27, 2021 · 2 comments · Fixed by #88
Closed

Extensions are not grouped under a folder #87

alvsan09 opened this issue Apr 27, 2021 · 2 comments · Fixed by #88
Assignees
Milestone

Comments

@alvsan09
Copy link

Bug Description:

The file structure is not following 'theia' or 'lerna' defaults where additional packages are consolidated
under a 'packages' folder.
So the top level project may continue to grow as extension get added which is not desirable as multiple projects may
extend a non optimal structure.

Steps to Reproduce:

  1. Open theia-blueprint repository in a file system and observe that the two existing extensions are under the top level project
    i.e. 'theia-blueprint-product' and 'theia-blueprint-updater'

Additional Information

I will submit a PR shortly after submitting this issue.

  • Operating System:
  • Theia Version:
@vince-fugnitto
Copy link
Member

@alvsan09 its a known optimization that @marechal-p and I talked about previously to re-organize the repo and also add linting #82. I believe that @marechal-p already did some reorganization in preparation for #74.

@alvsan09
Copy link
Author

@alvsan09 its a known optimization that @marechal-p and I talked about previously to re-organize the repo and also add linting #82. I believe that @marechal-p already did some reorganization in preparation for #74.

Ok, I have closed my intended PR to take Paul's PR #88 instead.

@jfaltermeier jfaltermeier added this to the Backlog milestone May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants