Swap Ministers Index GraphQL #joins for #includes #3042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yndajas
approved these changes
Dec 16, 2024
Ha, @yndajas, yeah, I guess "this" meant, like, "the bad option that's being replaced" 😆 |
mike3985
force-pushed
the
ministers-index-graphql-eagerload
branch
from
a6d02a4 to
d52a769
Compare
Because, despite looking very similar (to me), of these two methods, ActiveRecord only treats #includes as eagerloading. (For anybody not familiar, if we don't explicitly eagerload, we're implicitly lazy-loading. I.e. ActiveRecord will make separate database queries on our behalf for any associations that our codes accesses.) With my local data, this change reduced the number of database queries made in order to serve the Ministers Index page from 1144 down to 280.
mike3985
force-pushed
the
ministers-index-graphql-eagerload
branch
from
d52a769 to
41c9d7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap Ministers Index GraphQL #joins for #includes -- because #includes eagerloads the specified associations, whereas #joins does not do that.
With my local data, this reduced the number of database queries made in order to serve the Ministers Index page from 1144 down to 280.
https://trello.com/c/dhngeJLd/1493-measure-and-improve-performance-of-ministers-index-graphql