Merge pull request #3042 from alphagov/ministers-index-graphql-eagerload

Swap Ministers Index GraphQL #joins for #includes
alphagov · Dec 16, 2024 · 0e6b2aa · 0e6b2aa
2 parents 92d6dd0 + 41c9d7a
commit 0e6b2aa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/graphql/types/base_object.rb b/app/graphql/types/base_object.rb
@@ -12,7 +12,7 @@ def self.links_field(field_name_and_link_type, graphql_field_type)
       define_method(field_name_and_link_type.to_sym) do
         Edition
           .live
-          .joins(document: { reverse_links: :link_set })
+          .includes(document: { reverse_links: :link_set })
           .where(
             document: { locale: "en" },
             link_set: { content_id: object.content_id },

diff --git a/app/graphql/types/ministers_index_type.rb b/app/graphql/types/ministers_index_type.rb
@@ -61,7 +61,7 @@ class MinistersIndexPersonLinks < Types::BaseObject
         def role_appointments
           Edition
             .live
-            .joins(
+            .includes(
               document: {
                 reverse_links: { # role -> role_appointment
                   link_set: {