Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use component wrapper on step nav component #4482

Merged
merged 1 commit into from
Dec 17, 2024
+19 −12
Merged

Use component wrapper on step nav component #4482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* Add canonical_url value to GA4 page view tracking ([PR #4500](https://github.com/alphagov/govuk_publishing_components/pull/4500))
* Add margin_bottom option to component wrapper helper ([PR #4494](https://github.com/alphagov/govuk_publishing_components/pull/4494))
* Limit GA4 search term tracking to 500 characters ([PR #4496](https://github.com/alphagov/govuk_publishing_components/pull/4496))
* Use component wrapper on step nav component ([PR #4482](https://github.com/alphagov/govuk_publishing_components/pull/4482))

## 46.3.1

Expand Down
29 changes: 17 additions & 12 deletions app/views/govuk_publishing_components/components/_step_by_step_nav.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,24 @@
step_nav_helper = GovukPublishingComponents::Presenters::StepByStepNavHelper.new

disable_ga4 ||= false

component_helper = GovukPublishingComponents::Presenters::ComponentWrapperHelper.new(local_assigns)
component_helper.add_data_attribute({
module: "gemstepnav",
show_text: t("components.step_by_step_nav.show"),
hide_text: t("components.step_by_step_nav.hide"),
show_all_text: t("components.step_by_step_nav.show_all"),
hide_all_text: t("components.step_by_step_nav.hide_all")
})
component_helper.add_data_attribute({ module: "ga4-event-tracker", ga4_expandable: "", }) unless disable_ga4
component_helper.add_data_attribute({ remember: "" }) if remember_last_step
component_helper.add_data_attribute({ id: tracking_id }) if tracking_id
component_helper.add_class("gem-c-step-nav js-hidden")
component_helper.add_class("govuk-!-display-none-print") if small
component_helper.add_class("gem-c-step-nav--large") unless small
%>
<% if steps %>
<div
data-module="gemstepnav<% unless disable_ga4 %> ga4-event-tracker<% end %>"
<%= "data-ga4-expandable" unless disable_ga4 %>
class="gem-c-step-nav js-hidden <% if small %>govuk-!-display-none-print<% end %> <% unless small %>gem-c-step-nav--large<% end %>"
<%= "data-remember" if remember_last_step %>
<%= "data-id=#{tracking_id}" if tracking_id %>
data-show-text="<%= t("components.step_by_step_nav.show") %>"
data-hide-text="<%= t("components.step_by_step_nav.hide") %>"
data-show-all-text="<%= t("components.step_by_step_nav.show_all") %>"
data-hide-all-text="<%= t("components.step_by_step_nav.hide_all") %>"
>
<%= tag.div(**component_helper.all_attributes) do %>
<ol class="gem-c-step-nav__steps">
<% steps.each_with_index do |step, step_index| %>
<%
Expand Down Expand Up @@ -115,5 +120,5 @@
</li>
<% end %>
</ol>
</div>
<% end %>
<% end %>
1 change: 1 addition & 0 deletions app/views/govuk_publishing_components/components/docs/step_by_step_nav.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ body: |
- creating a new component allows further iteration without impacting the accordion
Background information relating to the testing and research behind this component can be found on the [Modelling Services wiki](https://gov-uk.atlassian.net/wiki/spaces/MS/pages) in Q2 to Q4, 2017/18.
uses_component_wrapper_helper: true
accessibility_criteria: |
The step by step navigation must:
Expand Down
Loading