Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use component wrapper on step nav component #4482

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use component wrapper on step nav component #4482

wants to merge 1 commit into from
+19 −12

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Dec 6, 2024 •
edited
Loading

What

  • Adds the component wrapper helper to the step by step navigation component.

Why

As the trello card states:

Standardising our components to use the component wrapper helper will reduce code, increase standardisation, and improve future feature implementation speed.

Visual changes

None.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4482 December 6, 2024 15:07 Inactive
@AshGDS AshGDS force-pushed the step-nav-component-wrapper branch from 02f3b4c to fb9781b Compare December 6, 2024 15:14
andysellick
andysellick approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@andysellick andysellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andysellick andysellick andysellick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AshGDS @andysellick @govuk-ci