Updates placeholder schema references #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1pretz1
changed the title
leenagupte
approved these changes
Sep 18, 2023
| @@ -325,7 +325,7 @@ def given_there_is_a_non_step_by_step_parent_page | |||
| end | |||
|
|
|||
| def not_step_by_step_content | |||
| not_step_by_step_content = random_item("placeholder") | |||
| not_step_by_step_content = random_item("generic") | |||
There was a problem hiding this comment.
Not a blocker, but I feel like we might end up having a similar problem with "generic" at some point. The only example in publishing-api lists "whitehall-frontend" as the rendering app, which is no longer true of anything.
There was a problem hiding this comment.
Good point 👍 I've switched all the references to guide now
KludgeKML
approved these changes
Sep 18, 2023
The placeholder schema was removed in [1]. Swaps over to using `guide`. [1]: alphagov/publishing-api#2493
1pretz1
force-pushed
the
update-schema-placeholder-reference
branch
from
8a3cf17 to
8ac2b6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The placeholder schema was removed in 1, causing CI to fail. Swaps over to using
guide.