Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display compatibility with hs-minor-mode #72

Closed
dabrahams opened this issue Nov 12, 2016 · 3 comments
Closed

Display compatibility with hs-minor-mode #72

dabrahams opened this issue Nov 12, 2016 · 3 comments

Comments

@dabrahams
Copy link

dabrahams commented Nov 12, 2016

If you customize hs-set-up-overlay as suggested in its documentation

(defun dwa/hs-ellipsis (ov)
  (when (overlay-get ov 'hs)
    (overlay-put ov 'display "▷…")))

(setq hs-set-up-overlay 'dwa/hs-ellipsis)

and then hide some things that cross line breaks, you get this effect:

fci

when without fci-mode, it looks like this:

no-fci

My theory, not having looked at the code, is that fci-mode needs to skip over hidden newlines when determining where to place the indicators.

This could be related to #54

@alpaker
Copy link
Owner

alpaker commented Nov 12, 2016

Hi Dave. Thanks for the report. I'm about 85% done with a rewrite of the package and will take a look at this issue after that's complete, but to be entirely honest compatibility might be hard to achieve. Conflict with other modes that alter end-of-line display is getting more and more and difficult to avoid. That's ultimately not surprising, as fci-mode is trying to create something like a background canvas on which to render buffer text, but does so using a mechanism--overlays--that's fundamentally an inline display mechanism. The impedance mismatch is such that Eli Zarestskii has declared that he hates working on display engine bugs associated with this mode.

All of which is to say that I'm considering declaring fci-mode to be end of life and turning to a reimplementation of the mode's functionality that hooks in to the display engine in a different way.

Sorry to veer off into an existential discussion of the future of the package. I just want to make sure expectations are realistic.

davep added a commit to davep/.emacs.d that referenced this issue May 22, 2017
It was clashing with company-mode:

https://twitter.com/davepdotorg/status/866642177706917888

and while trying to work out who the bug should be reported it, I stumbled
on:

alpaker/fill-column-indicator#72 (comment)

which would suggest there's a bigger issue here and I might run into other
problems. Really nice mode/idea, implements a thing I really like in
SublimeText, but doesn't look like it's a good mix for my usual setup.
@alpaker
Copy link
Owner

alpaker commented Jan 29, 2019

Just FYI, I'm abandoning this package and welcoming requests to be take over as maintainer.

@alpaker
Copy link
Owner

alpaker commented Aug 6, 2020

The functionality provided by this package has now been implemented natively in Emacs as display-fill-column-indicator-mode, available as of version 27.0.90. Unless you are forced to use an older Emacs, you should use the native implementation instead of fci-mode. The former is unaffected by most of the compatibility issues that this add-on has.

@alpaker alpaker closed this as completed Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants