-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display compatibility issue with company-mode #54
Comments
We'll probably have to fix it in If the situation can be improved on this side, though, that would be even better. |
The problem in the screenshot in the linked company-mode issue is caused by the bug/undefined behavior triggered by this package, described in debbugs:18417. The problem described here should be somewhat easier to fix, but there's not much point in doing that, I think, until there's a workaround in place for the other problem. |
As I commented in the debbugs thread, I'll try to simplify the implementation so as to avoid undefined behavior in the Emacs display engine. We'll see if that suffices to avoid both problems. |
I've pushed a change that works around one of them, which leaves just the issue with |
Is there any progress on this issue? Edit: fci-mode also breaks auto-complete's quick help. |
Status update? |
I've encountered another display issue with fci-mode + hideshow-mode. That has prompted me to stop using fci-mode for the moment as there are too many incompatibilities with other modes I'm using (and likely other modes I might use in the future). Maybe a wiki/FAQ entry for compatibility issues would be useful? |
Any news on this one? I am using Emacs24 with the usual MELPA packages, and company + fci-mode still don't play nice together. |
Dupe of #21. |
https://github.com/alpaker/Fill-Column-Indicator/issues/21 has a discussion. (defun on-off-fci-before-company(command)
(when (string= "show" command)
(turn-off-fci-mode))
(when (string= "hide" command)
(turn-on-fci-mode)))
(advice-add 'company-call-frontends :before #'on-off-fci-before-company)
|
Use company everywhere. Remove company color face settings. Disable fill-column-indicator during completion: alpaker/fill-column-indicator#54 Signed-off-by: Matteo Cafasso <[email protected]>
Just FYI, I'm abandoning this package and welcoming requests to be take over as maintainer. |
Thanks @alpaker for the heads up. Please consider indicating status and inviting new maintainers on https://www.emacswiki.org/emacs/FillColumnIndicator as well. |
The functionality provided by this package has now been implemented natively in Emacs as |
I've updated the emacswiki page as well. |
When
fci-mode
is enabled and acompany-mode
auto-complete popup shows up, the first completion item is moved beyond the ruler. See screenshot.The text was updated successfully, but these errors were encountered: