Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display compatibility issue with company-mode #54

Closed
john2x opened this issue Aug 31, 2014 · 14 comments
Closed

Display compatibility issue with company-mode #54

john2x opened this issue Aug 31, 2014 · 14 comments

Comments

@john2x
Copy link

john2x commented Aug 31, 2014

When fci-mode is enabled and a company-mode auto-complete popup shows up, the first completion item is moved beyond the ruler. See screenshot.

__projects_clojure_ledgerview_src_ledgerview_ledger_core_clj

@dgutov
Copy link

dgutov commented Sep 6, 2014

We'll probably have to fix it in company-mode (company-mode/company-mode#180).

If the situation can be improved on this side, though, that would be even better.

@dgutov
Copy link

dgutov commented Sep 7, 2014

The problem in the screenshot in the linked company-mode issue is caused by the bug/undefined behavior triggered by this package, described in debbugs:18417.

The problem described here should be somewhat easier to fix, but there's not much point in doing that, I think, until there's a workaround in place for the other problem.

@alpaker
Copy link
Owner

alpaker commented Sep 7, 2014

As I commented in the debbugs thread, I'll try to simplify the implementation so as to avoid undefined behavior in the Emacs display engine. We'll see if that suffices to avoid both problems.

@dgutov
Copy link

dgutov commented Sep 9, 2014

I've pushed a change that works around one of them, which leaves just the issue with posn-col-row, I think.

@mbrgm
Copy link

mbrgm commented Dec 28, 2014

Is there any progress on this issue?

Edit: fci-mode also breaks auto-complete's quick help.

@hunterboerner
Copy link

Status update?

@john2x
Copy link
Author

john2x commented Aug 9, 2015

I've encountered another display issue with fci-mode + hideshow-mode. That has prompted me to stop using fci-mode for the moment as there are too many incompatibilities with other modes I'm using (and likely other modes I might use in the future).

Maybe a wiki/FAQ entry for compatibility issues would be useful?

@root42
Copy link

root42 commented Aug 13, 2015

Any news on this one? I am using Emacs24 with the usual MELPA packages, and company + fci-mode still don't play nice together.

@eigengrau
Copy link

Dupe of #21.

@sukiida
Copy link

sukiida commented May 11, 2016

https://github.com/alpaker/Fill-Column-Indicator/issues/21 has a discussion.
I translate purcell's workaround into new form of advice and it works for me with emacs24.5.1 and company mode.
my code is like this:

(defun on-off-fci-before-company(command)
  (when (string= "show" command)
    (turn-off-fci-mode))
  (when (string= "hide" command)
    (turn-on-fci-mode)))

(advice-add 'company-call-frontends :before #'on-off-fci-before-company)

purcell commented on 13 Jul 2012

I just wanted to note, particularly for the benefit of @alpaker, that you can work around this problem by temporarily suspending fci-mode while popups are being displayed:

(defvar sanityinc/fci-mode-suppressed nil)
(defadvice popup-create (before suppress-fci-mode activate)
."Suspend fci-mode while popups are visible"
(set (make-local-variable 'sanityinc/fci-mode-suppressed) fci-mode)
(when fci-mode
(turn-off-fci-mode)))
(defadvice popup-delete (after restore-fci-mode activate)
"Restore fci-mode when all popups have closed"
(when (and (not popup-instances) sanityinc/fci-mode-suppressed)
(setq sanityinc/fci-mode-suppressed nil)
(turn-on-fci-mode)))

noxdafox added a commit to noxdafox/emacs-settings that referenced this issue Nov 13, 2016
Use company everywhere.

Remove company color face settings.

Disable fill-column-indicator during completion:
alpaker/fill-column-indicator#54

Signed-off-by: Matteo Cafasso <[email protected]>
@alpaker
Copy link
Owner

alpaker commented Jan 29, 2019

Just FYI, I'm abandoning this package and welcoming requests to be take over as maintainer.

@posita
Copy link

posita commented Jan 29, 2019

Just FYI, I'm abandoning this package and welcoming requests to be take over as maintainer.

Thanks @alpaker for the heads up. Please consider indicating status and inviting new maintainers on https://www.emacswiki.org/emacs/FillColumnIndicator as well.

@alpaker
Copy link
Owner

alpaker commented Aug 6, 2020

The functionality provided by this package has now been implemented natively in Emacs as display-fill-column-indicator-mode, available as of version 27.0.90. Unless you are forced to use an older Emacs, you should use the native implementation instead of fci-mode. The former is unaffected by most of the compatibility issues that this add-on has.

@alpaker alpaker closed this as completed Aug 6, 2020
@alpaker
Copy link
Owner

alpaker commented Aug 6, 2020

I've updated the emacswiki page as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants