chore: update zip dependency
#62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
mattsse
requested changes
Sep 25, 2022
There was a problem hiding this comment.
this is a reasonable request, could eventually impact ethers-rs as well.
binstall-zip is published on crates.io so instead of importing via git, let's apply the same change that was added here cargo-bins/cargo-binstall#375
agostbiro
added a commit
to agostbiro/svm-rs
that referenced
this pull request
Sep 26, 2022
The previous version of the zip package has an outdated transitive Rust Crypto dependency that conflicts with newer Rust Crytpo crates, so it's important to update. The master branch of the `zip` package already contains the new Rust Crytpo dependencies, but it's been waiting for a release for three months now so this commit switches to the updated `binstall-zip` fork by the `cargo-bins` team. Fore more context, please see: alloy-rs#62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of the
zippackage has an outdatedtransitive Rust Crypto dependency that conflicts with newer
Rust Crytpo crates.
The master branch of the
zippackage already contains the newRust Crytpo dependencies, but it's waiting
for a release for three months now so I've specified the latest
commit in the master branch as the
zipversion.