Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream problem: Maintain a fork of zip #356

Closed
NobodyXu opened this issue Sep 9, 2022 · 2 comments · Fixed by #375
Closed

Upstream problem: Maintain a fork of zip #356

NobodyXu opened this issue Sep 9, 2022 · 2 comments · Fixed by #375
Assignees
Labels
Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency)

Comments

@NobodyXu
Copy link
Member

NobodyXu commented Sep 9, 2022

According to the maintainer of zip @zamazan4ik :

The library is almost dead, so...

Also @zamazan4ik has no permission to publish a new version, so updates/bug fixes from zip is pretty slow.

Also, one of my PR which is intended to be used in cargo-binstall is also currently blocking as it requires reviewing from @Plecra but they don't have time/effort to review.

Honestly, I don't like forking upstream projects, but it seems that they are really in a bad shape. zip-rs/zip-old#232

@NobodyXu NobodyXu added the Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency) label Sep 9, 2022
@passcod
Copy link
Member

passcod commented Sep 9, 2022

I'm for it on the condition that these two (with tar) are forked under the name binstall-zip and binstall-tar and have an explicit mission of upstreaming changes (so no wild rewrites) and eventually disappearing (however that happens). Essentially we'll be keeping a patchset like distros sometimes do, not taking on the entire project.

@NobodyXu
Copy link
Member Author

NobodyXu commented Sep 9, 2022

@passcod I agree with you on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked: upstream Fix or feature is needed to be implemented upstream (in a dependency)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants