Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Support PHPUnit 10" from 0.12.x #475

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Revert "Support PHPUnit 10" from 0.12.x #475

merged 5 commits into from
Nov 27, 2023

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented Nov 21, 2023 •
edited
Loading

Reverts #427

Aims to reapply PHPUnit 10 support in 1.x.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Nov 21, 2023 •
edited
Loading

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. Skipping review to prevent low quality review.

54 files out of 126 files are above the max files limit of 50.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@srtfisher srtfisher closed this Nov 21, 2023
@srtfisher srtfisher reopened this Nov 27, 2023
@srtfisher srtfisher closed this Nov 27, 2023
@srtfisher srtfisher reopened this Nov 27, 2023
@srtfisher srtfisher merged commit 9b6517e into 0.12.x Nov 27, 2023
13 of 15 checks passed
@srtfisher srtfisher deleted the revert-427-phpunit-10 branch November 27, 2023 21:12
srtfisher added a commit that referenced this pull request Nov 27, 2023
@srtfisher
Revert "Revert "Support PHPUnit 10" from 0.12.x (#475)"
281d3a6 
This reverts commit 9b6517e.
srtfisher added a commit that referenced this pull request Nov 29, 2023
@srtfisher
[1.x] PHPUnit 10 (#477)
3bca64a 
* Revert "Revert "Support PHPUnit 10" from 0.12.x (#475)"

This reverts commit 9b6517e.

* Fixing versions
srtfisher added a commit that referenced this pull request Nov 29, 2023
@srtfisher
[1.x] Adding backed enum support to query builder for meta (#478)
0dc7855 
* Revert "Revert "Support PHPUnit 10" from 0.12.x (#475)"

This reverts commit 9b6517e.

* Fixing versions

* Adding enum support to meta and query builder

* Remove unused ref

* Use only enum on the query builder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@srtfisher