Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHPUnit 10 #427

Merged
merged 14 commits into from
Nov 21, 2023
Merged

Support PHPUnit 10 #427

merged 14 commits into from
Nov 21, 2023

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented Aug 15, 2023 •
edited
Loading

  • Ensure that PHPUnit 10 runs properly.
  • Determine path forward for file naming (PHPUnit 10 breaks this).
  • Upgrade create-wordpress-plugin to use PSR4 standards for tests.
  • Migrate tests in Mantle to PSR4.

For Alleyinz: https://l.alley.dev/b65c9e7aa2

renatonascalves
renatonascalves reviewed Aug 16, 2023
View reviewed changes
phpunit.xml
@@ -1,15 +1,15 @@
<?xml version="1.0"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this config works for PHPUnit <10? The way I understood it, it doesn't.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may or may not but the framework is only using a single version in this PR (~10).

@srtfisher srtfisher changed the title [DRAFT] PHPUnit 10 [DRAFT] Support PHPUnit 10 Nov 15, 2023
@srtfisher srtfisher self-assigned this Nov 15, 2023
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Nov 16, 2023 •
edited
Loading

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. Skipping review to prevent low quality review.

56 files out of 124 files are above the max files limit of 50.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@srtfisher srtfisher changed the title [DRAFT] Support PHPUnit 10 Support PHPUnit 10 Nov 17, 2023
@srtfisher srtfisher mentioned this pull request Nov 17, 2023
Merged
attackant
attackant approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@attackant attackant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐙

@srtfisher srtfisher marked this pull request as ready for review November 21, 2023 14:00
@srtfisher srtfisher merged commit 9ba62e1 into 0.12.x Nov 21, 2023
15 checks passed
@srtfisher srtfisher deleted the phpunit-10 branch November 21, 2023 14:13
srtfisher added a commit that referenced this pull request Nov 21, 2023
@srtfisher
Revert "Support PHPUnit 10 (#427)"
bff2b08 
This reverts commit 9ba62e1.
@srtfisher srtfisher mentioned this pull request Nov 21, 2023
Merged
srtfisher added a commit that referenced this pull request Nov 27, 2023
@srtfisher
Revert "Support PHPUnit 10" from 0.12.x (#475)
9b6517e 
* Revert "Support PHPUnit 10 (#427)"

This reverts commit 9ba62e1.

* Fixing unit tests for wordpress 6.4

* CHANGELOG
@srtfisher srtfisher mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatonascalves renatonascalves renatonascalves left review comments

@attackant attackant attackant approved these changes

Assignees

@srtfisher srtfisher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srtfisher @attackant @renatonascalves