Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gripper-arm open-close implementation #1050

Merged
merged 14 commits into from
Aug 18, 2022
Merged

Gripper-arm open-close implementation #1050

merged 14 commits into from
Aug 18, 2022

Conversation

elimvb
Copy link
Collaborator

@elimvb elimvb commented Aug 2, 2022

Full addition of gripper-arm open-close functionality, including a full overhaul of underlying logic that removes iTween

elimvb added 13 commits June 22, 2022 14:43
@elimvb
Made iTween animations compatible with non-automated physics sims, an…
448e812 
…d allowed custom physics-step to be passed in
@elimvb
Implemented early prototype of working gripper open-close functionality
ba1cef6
@elimvb
Added much more robust gripper-opening functionality, including frame…
5b65b2e 
…-by-frame collision and hyperextension checks
@elimvb
Added stopAtNonStaticColiiders condition for open-close action
f50b78e
@elimvb
Removed iTween entirely from open-close logic
2ccb05a
@elimvb
Added counters and cabinets to drawers' and doors' "Ignore" arrays
818283a
@elimvb
Finished Ignore Array update
930623b
@elimvb
Added more metadata resets so arm-opening logic will perform consiste…
1bdaa71 
…ntly
@elimvb
Fully removed iTween from THOR, and all of the logic that uses it
13ee9b9
@elimvb
Added forceAction and ignoreAgentInTransition edge-cases
a5c42a5
@elimvb
Removed debug comments from CanOpenObject script
721c445
@elimvb
Added condition in open-close trigger-event logic to exclude trigger …
2b57c6c 
…colliders as disqualifiers
@elimvb
Removed final unnecessary comments from OnOff logic
d674a6f
@lgtm-com
Copy link

lgtm-com bot commented Aug 2, 2022

This pull request introduces 2 alerts and fixes 1 when merging d674a6f into ce11987 - view on LGTM.com

new alerts:

  • 1 for Use of default ToString()
  • 1 for Dereferenced variable may be null

fixed alerts:

  • 1 for Use of default ToString()

@lgtm-com
Copy link

lgtm-com bot commented Aug 8, 2022

This pull request introduces 2 alerts and fixes 1 when merging 1a9bd54 into e40b5f9 - view on LGTM.com

new alerts:

  • 1 for Use of default ToString()
  • 1 for Dereferenced variable may be null

fixed alerts:

  • 1 for Use of default ToString()

@elimvb elimvb merged commit ae30c8f into main Aug 18, 2022
elimvb added a commit that referenced this pull request Aug 23, 2022
@elimvb
Revert "Merge pull request #1050 from allenai/Open-CloseWithAgentArm"
675d451 
This reverts commit ae30c8f, reversing
changes made to a4a5a6c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lucaweihs Lucaweihs Awaiting requested review from Lucaweihs

@AlvaroHG AlvaroHG Awaiting requested review from AlvaroHG

@winthos winthos Awaiting requested review from winthos

@mattdeitke mattdeitke Awaiting requested review from mattdeitke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elimvb