generated from alkemyTech/base-ong-server-js
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Envío de email a usuario registrado #43
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3fad74b
Envío de email a usuario registrado
Alvaro1599 d2680bd
Merge remote-tracking branch 'origin/development' into OT-32_Send-email
Alvaro1599 525b040
se eliminó console.log
Alvaro1599 8997670
Se pasço método send email a POO
Alvaro1599 130f6b7
se cambiaron los atributos estáticos subject y welcomeText para tener…
Alvaro1599 b637612
update branch
Alvaro1599 8078b46
envío de email terminado
Alvaro1599 fac4153
Merge remote-tracking branch 'origin/development' into OT-32_Send-email
Alvaro1599 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,47 @@ | ||
require('dotenv').config(); | ||
const path = require("path") | ||
const fs = require("fs") | ||
const sgMail = require('@sendgrid/mail'); | ||
class NotifyViaEmail { | ||
constructor(email, subject, contentHtml){ | ||
this.email=email; | ||
this.subject=subject; | ||
this.contentHtml=contentHtml; | ||
} | ||
sendEmail = async () => { | ||
sgMail.setApiKey(process.env.API_KEY); | ||
await sgMail.send({ | ||
to: email, | ||
from: '[email protected]', | ||
subject: subject, | ||
html: contentHtml | ||
}); | ||
} | ||
static logo = "https://firebasestorage.googleapis.com/v0/b/aplication1-35a9f.appspot.com/o/LOGO-SOMOS%20MAS.png?alt=media&token=0f852ec5-0c90-42af-aead-7ebe0f0b893a" | ||
static subject="Confirmación de Registro" | ||
static organizationName="SOMOS MAS" | ||
static welcomeText="Bienvenido" | ||
static contactData="[email protected]" | ||
static HtmlToString() { | ||
try { | ||
|
||
return fs.readFileSync(path.resolve("assets/email/plantilla_email.html"), { encoding: "utf-8" }, (err, data) => { | ||
if (err) { | ||
return err | ||
} | ||
console.log(data,typeof data); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: console.log usar solo para debugear. |
||
return data | ||
}) | ||
} catch (error) { | ||
throw new Error(error) | ||
} | ||
} | ||
static sendEmail = async (email,) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pasar a POO. |
||
sgMail.setApiKey(process.env.API_KEY); | ||
await sgMail.send({ | ||
to: email, | ||
from: NotifyViaEmail.contactData, | ||
subject: NotifyViaEmail.subject, | ||
html: NotifyViaEmail.HtmlToString(), | ||
personalizations: [ | ||
{to:[{ | ||
"email":email | ||
}], | ||
substitutions: { | ||
"ongLogo": NotifyViaEmail.logo, | ||
"organizationName": NotifyViaEmail.organizationName, | ||
"welcomeText": NotifyViaEmail.welcomeText, | ||
"contactData": NotifyViaEmail.contactData | ||
}, | ||
} | ||
] | ||
}); | ||
} | ||
} | ||
module.exports = NotifyViaEmail; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: dejaría algunas variables asociadas a una función de envío de bienvenida, así no es reutilizable para otra cosa.