Envío de email a usuario registrado #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Se realizó integración de envío de email al usuario registrado |
services/notifyViaEmail.js
Outdated
| if (err) { | ||
| return err | ||
| } | ||
| console.log(data,typeof data); |
There was a problem hiding this comment.
nit: console.log usar solo para debugear.
services/notifyViaEmail.js
Outdated
| throw new Error(error) | ||
| } | ||
| } | ||
| static sendEmail = async (email,) => { |
services/notifyViaEmail.js
Outdated
| static logo = "https://firebasestorage.googleapis.com/v0/b/aplication1-35a9f.appspot.com/o/LOGO-SOMOS%20MAS.png?alt=media&token=0f852ec5-0c90-42af-aead-7ebe0f0b893a" | ||
| static subject="Confirmación de Registro" | ||
| static organizationName="SOMOS MAS" | ||
| static welcomeText="Bienvenido" |
There was a problem hiding this comment.
nit: dejaría algunas variables asociadas a una función de envío de bienvenida, así no es reutilizable para otra cosa.
… mayor reutilización del servicio
| throw new Error(error) | ||
| } | ||
| } | ||
| static async sendEmail(email,subject,welcomeText) { |
There was a problem hiding this comment.
nit: Esta función solo reconoce envío de bienvenida, tener en cuenta si se quiere extender.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.