Support arbitrary statistic interval for flow control && stat parameters configurable #200

louyuting · 2020-08-04T13:51:48Z

Describe what this PR does / why we need it

Support arbitrary statistic interval for normal flow rule
stat parameters configurable

Does this pull request fix one issue?

Resolve
#129
#167

Describe how you did it

Support arbitrary statistic interval for normal flow rule

If user doesn't set StatisticConfig, that means using default metric statistic.
2.If user specifies StatisticConfig and meets the compliance of CheckValidityForReuseStatistic,
will build readonly metric statistic based on resource's global statistic.
3.If user specifies StatisticConfig and doesn't meet the compliance of CheckValidityForReuseStatistic,
will generate independent token bucket statistic for this rule.

Describe how to verify it

TODO

unit test
integration test

Special notes for reviews

codecov-commenter · 2020-08-04T14:01:04Z

Codecov Report

Merging #200 into master will increase coverage by 1.17%.
The diff coverage is 57.02%.

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   41.89%   43.06%   +1.17%     
==========================================
  Files          77       79       +2     
  Lines        3817     3994     +177     
==========================================
+ Hits         1599     1720     +121     
- Misses       1977     2009      +32     
- Partials      241      265      +24

Impacted Files	Coverage Δ
core/config/config.go	`21.50% <0.00%> (-1.23%)`	⬇️
core/flow/tc_warm_up.go	`0.00% <0.00%> (ø)`
core/config/entity.go	`51.51% <50.00%> (-0.28%)`	⬇️
core/flow/rule.go	`19.04% <50.00%> (+19.04%)`	⬆️
core/flow/tc_throttling.go	`62.96% <50.00%> (-1.04%)`	⬇️
core/flow/rule_manager.go	`61.06% <55.76%> (+0.07%)`	⬆️
core/stat/base/sliding_window_metric.go	`17.82% <60.00%> (-4.56%)`	⬇️
core/flow/standalone_stat_slot.go	`66.66% <66.66%> (ø)`
core/base/stat.go	`78.57% <78.57%> (ø)`
core/flow/tc_default.go	`68.75% <81.81%> (+46.52%)`	⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ddba92...cf49660. Read the comment docs.

louyuting · 2020-08-14T15:30:41Z

@sczyh30 Could you please review this large PR?

core/flow/rule_manager.go

core/base/stat.go

core/config/entity.go

core/flow/rule_manager.go

sczyh30 · 2020-09-22T16:17:47Z

And we may need to support the scenario when only one of sampleCount or intervalMs is provided (use the default value for another).

core/flow/tc_default.go

sczyh30

LGTM

sczyh30 · 2020-09-25T15:23:17Z

Awesome. Thanks!

louyuting force-pushed the 20200801-statistci-configurable branch from f28d2b9 to bd7baec Compare August 4, 2020 16:39

sczyh30 added area/flow-control Issues or PRs related to flow control kind/feature Category issues or PRs related to feature request size/XXL Indicate a PR that changes 1000+ lines. labels Aug 5, 2020

louyuting force-pushed the 20200801-statistci-configurable branch 2 times, most recently from e9f2d77 to 77c9ad4 Compare August 6, 2020 14:29

louyuting requested a review from sczyh30 August 6, 2020 14:32

This was linked to issues Aug 10, 2020

Break down flow rule as different rule based on ControlBehavior #35

Closed

Enable configuration for sample count & interval of leap array #129

Closed

Support arbitrary statistic interval for normal flow rule #167

Closed

louyuting force-pushed the 20200801-statistci-configurable branch from 77c9ad4 to 5205051 Compare August 12, 2020 15:47

louyuting added this to the 0.6.0 milestone Aug 14, 2020

louyuting marked this pull request as ready for review August 14, 2020 15:26

sczyh30 self-assigned this Aug 17, 2020

louyuting added the to-review PRs to review label Aug 17, 2020

louyuting force-pushed the 20200801-statistci-configurable branch 4 times, most recently from 85dc2ce to 875060e Compare August 23, 2020 04:44

yunfeiyanggzq reviewed Aug 25, 2020

View reviewed changes

core/flow/rule_manager.go Outdated Show resolved Hide resolved

core/flow/rule_manager.go Outdated Show resolved Hide resolved

yunfeiyanggzq reviewed Aug 25, 2020

View reviewed changes

core/flow/rule_manager.go Outdated Show resolved Hide resolved

core/flow/rule_manager.go Outdated Show resolved Hide resolved

yunfeiyanggzq reviewed Aug 25, 2020

View reviewed changes

core/base/stat.go Outdated Show resolved Hide resolved

louyuting force-pushed the 20200801-statistci-configurable branch from 875060e to 444dfe2 Compare August 25, 2020 12:19

louyuting removed this from the 0.6.0 milestone Aug 27, 2020

binbin0325 reviewed Aug 30, 2020

View reviewed changes

core/base/stat.go Outdated Show resolved Hide resolved

core/config/entity.go Show resolved Hide resolved

louyuting added this to the 0.7.0 milestone Sep 2, 2020

louyuting changed the title ~~Support arbitrary statistic interval for normal flow rule/stat parameters configurable/break down ControlBehavior~~ Support arbitrary statistic interval for flow control && stat parameters configurable Sep 8, 2020

louyuting force-pushed the 20200801-statistci-configurable branch from ede8121 to 2d2bf98 Compare September 8, 2020 16:21

louyuting force-pushed the 20200801-statistci-configurable branch from 2d2bf98 to 854ed30 Compare September 8, 2020 16:30

louyuting commented Sep 8, 2020

View reviewed changes

core/flow/rule_manager.go Show resolved Hide resolved

louyuting force-pushed the 20200801-statistci-configurable branch from 854ed30 to 05e9d1f Compare September 9, 2020 16:14

louyuting removed the size/XXL Indicate a PR that changes 1000+ lines. label Sep 10, 2020

louyuting force-pushed the 20200801-statistci-configurable branch from 05e9d1f to 00ebf30 Compare September 20, 2020 09:38

louyuting modified the milestones: 0.7.0, 1.0.0 Sep 20, 2020

louyuting force-pushed the 20200801-statistci-configurable branch 2 times, most recently from 0b57285 to cc1d73c Compare September 22, 2020 14:50

sczyh30 added the size/XXL Indicate a PR that changes 1000+ lines. label Sep 22, 2020

sczyh30 reviewed Sep 22, 2020

View reviewed changes

core/flow/rule_manager.go Outdated Show resolved Hide resolved

core/flow/rule_manager.go Outdated Show resolved Hide resolved

louyuting mentioned this pull request Sep 23, 2020

Rule Manager: flow module supports resource level replacement #244

Closed

flow module support arbitrary interval

79a18bf

louyuting force-pushed the 20200801-statistci-configurable branch from fcb4269 to 79a18bf Compare September 23, 2020 14:44

rename magic number

15235f7

sczyh30 requested changes Sep 23, 2020

View reviewed changes

core/flow/tc_default.go Outdated Show resolved Hide resolved

louyuting added 2 commits September 24, 2020 00:53

make meaning of request number per interval

8dd056a

make flow.Rule.StatIntervalInMs as millisecond precision

cf49660

sczyh30 approved these changes Sep 25, 2020

View reviewed changes

sczyh30 merged commit 4e8f5a0 into alibaba:master Sep 25, 2020

sczyh30 removed the to-review PRs to review label Sep 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support arbitrary statistic interval for flow control && stat parameters configurable #200

Support arbitrary statistic interval for flow control && stat parameters configurable #200

louyuting commented Aug 4, 2020 •

edited

Loading

codecov-commenter commented Aug 4, 2020 •

edited

Loading

louyuting commented Aug 14, 2020

sczyh30 commented Sep 22, 2020

sczyh30 left a comment

sczyh30 commented Sep 25, 2020

Support arbitrary statistic interval for flow control && stat parameters configurable #200

Support arbitrary statistic interval for flow control && stat parameters configurable #200

Conversation

louyuting commented Aug 4, 2020 • edited Loading

Describe what this PR does / why we need it

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

codecov-commenter commented Aug 4, 2020 • edited Loading

Codecov Report

louyuting commented Aug 14, 2020

sczyh30 commented Sep 22, 2020

sczyh30 left a comment

Choose a reason for hiding this comment

sczyh30 commented Sep 25, 2020

louyuting commented Aug 4, 2020 •

edited

Loading

codecov-commenter commented Aug 4, 2020 •

edited

Loading