Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arbitrary statistic interval for normal flow rule #167

Closed
sczyh30 opened this issue Jun 19, 2020 · 1 comment · Fixed by #200
Closed

Support arbitrary statistic interval for normal flow rule #167

sczyh30 opened this issue Jun 19, 2020 · 1 comment · Fixed by #200
Assignees
@louyuting
Labels
area/flow-control Issues or PRs related to flow control kind/feature Category issues or PRs related to feature request
Milestone
1.0.0

Comments

@sczyh30
Copy link
Member

sczyh30 commented Jun 19, 2020

Issue Description

Type: feature request

Describe what feature you want

Support arbitrary statistic interval for normal flow control rule (i.e. flow.Rule). We may leverage token bucket mechanism to accomplish this (for time span > interval of the sliding window). Discussions are welcomed.
@sczyh30 sczyh30 added kind/feature Category issues or PRs related to feature request area/flow-control Issues or PRs related to flow control labels Jun 19, 2020
@sczyh30 sczyh30 added this to the 1.0.0 milestone Jul 21, 2020
@louyuting louyuting self-assigned this Jul 31, 2020
@louyuting
Copy link
Collaborator

louyuting commented Aug 1, 2020 •
edited
Loading

associated with #129 #35

@louyuting louyuting mentioned this issue Aug 4, 2020
Merged
@louyuting louyuting linked a pull request Aug 10, 2020 that will close this issue
Support arbitrary statistic interval for flow control && stat parameters configurable #200
Merged
@louyuting louyuting modified the milestones: 1.0.0, 0.7.0 Sep 2, 2020
@sczyh30 sczyh30 modified the milestones: 0.7.0, 1.0.0 Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louyuting louyuting

Labels
area/flow-control Issues or PRs related to flow control kind/feature Category issues or PRs related to feature request
Projects
None yet
Milestone
1.0.0
2 participants
@louyuting @sczyh30