Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: add support for tf25 py3 test #255

Merged
merged 7 commits into from
Jul 26, 2022

Conversation

chengmengli06
Copy link
Collaborator

add support for tf25 py3 test

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ yangxudong
✅ tiankongdeguiji
❌ chengmengli06
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

CI PY3 Test Failed

@github-actions
Copy link

CI Test Failed

@github-actions
Copy link

CI PY3 Test Failed

@github-actions
Copy link

CI PY3 Test Failed

@github-actions
Copy link

CI Test Passed

@github-actions github-actions bot added ci_test_passed ci test passed and removed ci_test_failed labels Jul 24, 2022
@github-actions
Copy link

CI PY3 TF25 Test Failed

@github-actions
Copy link

CI PY3 Test Passed

@github-actions
Copy link

CI PY3 TF25 Test Failed

@github-actions
Copy link

CI PY3 Test Passed

@github-actions
Copy link

CI PY3 TF25 Test Failed

@github-actions
Copy link

CI Test Passed

@github-actions github-actions bot added ci_test_passed ci test passed and removed ci_test_passed ci test passed labels Jul 25, 2022
@github-actions
Copy link

CI PY3 Test Failed

@github-actions
Copy link

CI PY3 TF25 Test Failed

@github-actions
Copy link

CI Test Passed

@github-actions github-actions bot removed the ci_test_passed ci test passed label Jul 25, 2022
@github-actions
Copy link

CI PY3 Test Passed

@github-actions
Copy link

CI PY3 TF25 Test Failed

@github-actions
Copy link

CI Test Passed

@github-actions github-actions bot added the ci_test_passed ci test passed label Jul 25, 2022
@github-actions
Copy link

CI PY3 Test Passed

@github-actions
Copy link

CI PY3 TF25 Test Passed

@github-actions
Copy link

CI Test Passed

@github-actions github-actions bot added ci_test_passed ci test passed and removed ci_test_passed ci test passed labels Jul 25, 2022
@@ -634,8 +634,8 @@ def test_dssm_sample_weight(self):
self.assertTrue(self._success)

@unittest.skipIf(
LooseVersion(tf.__version__) < LooseVersion('2.3.0'),
'MultiWorkerMirroredStrategy need tf version > 2.3')
LooseVersion(tf.__version__) != LooseVersion('2.3.0'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是什么意思,tf 2.3 版本不支持吗

@@ -0,0 +1,115 @@
name: CI Build PY3 TF25
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥不是一步到位,支持 tf 2.9 呢

with self.test_session() as sess:
loss_val = sess.run(loss)
self.assertAlmostEqual(loss_val, 0.76977473, delta=1e-5)
self.assertAlmostEqual(loss_val, 0.48577175, delta=1e-5)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个之前的测试是怎么过的

@chengmengli06 chengmengli06 merged commit 5011311 into master Jul 26, 2022
@chengmengli06 chengmengli06 deleted the add_py37_tf25_unit_test branch October 12, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants