docs(two-column-layout-example): add categories, brands and faq plugins #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e0c3ff1:
|
7 tasks
FabienMotte
force-pushed
the
docs/two-columns-layout-example-2
branch
from
6b57c2e to
d988a02
Compare
FabienMotte
force-pushed
the
docs/two-columns-layout-example-3
branch
from
3b137f9 to
5c6bc07
Compare
FabienMotte
requested review from
a team,
dhayab and
Haroenv
and removed request for
a team
sarahdayan
reviewed
Mar 8, 2022
There was a problem hiding this comment.
A few comments:
- All three plugins seem to share exactly the same logic, the only things that change are the data and templates. Would it make sense to have a single plugin?
- The tag icon seems to be missing the top punch and the info icon seems to be missing the dot on the "i".
- I find the uppercase letters in the breadcrumb a bit blocky. Wdyt about just capitalizing it?
- Right before going into mobile view, the products stretch a lot in height, the prices "break" on several lines and so do the product names. Maybe we could limit it with line clamps and going with two rows?
FabienMotte
changed the title
FabienMotte
force-pushed
the
docs/two-columns-layout-example-2
branch
2 times, most recently
from
47c2540 to
f26f445
Compare
FabienMotte
force-pushed
the
docs/two-columns-layout-example-3
branch
from
5c6bc07 to
19f5ee9
Compare
@sarahdayan All 3 plugins don't share much code, I don't see how would you do it? |
FabienMotte
force-pushed
the
docs/two-columns-layout-example-3
branch
from
a350612 to
3a5daa8
Compare
Have we tried smallcaps? |
Seems fine to me with small caps!
|
|
Not a fan of smallcaps 😀 I personally think regular case works better. |
FabienMotte
force-pushed
the
docs/two-columns-layout-example-2
branch
from
f26f445 to
f2306a9
Compare
FabienMotte
force-pushed
the
docs/two-columns-layout-example-3
branch
from
3a5daa8 to
be9bcf5
Compare
* chore(two-columns-layout-example): add articles plugin * chore(two-columns-layout-example): add popular plugin * apply suggestions from code review * docs(two-column-layout-example): add reshape functions and quick access plugin (#912) * chore(two-columns-layout-example): add reshape functions * docs(two-columns-layout-example): add quick access plugin * chore: move reshape functions at file top-level * apply suggestions from code review * docs(two-column-layout-example): add smart preview feature (#913) * docs(two-columns-layout-example): add smart preview feature * docs(two-columns-layout-example): add faq article preview * apply suggestions from code review * docs(two-column-layout-example): add no results state and popular categories plugin (#914) * docs(two-columns-layout-example): add no results state and popular categories plugin * chore: fix empty div with Fragment * chore: fix empty div when no recent searches exist * chore: fix casing * apply suggestions from code review * apply suggestions from pair session * fix empty recent searches * fix linting * apply suggestion from code review * smart preview no longer depends on the DOM * apply suggestions from feedback * apply suggestions from feedback * apply suggestion from code review * apply suggestion from feedback
FabienMotte
added a commit
that referenced
this pull request
Mar 28, 2022
* docs(two-columns-layout-example): add products plugin * apply suggestions from review * remove useless type * use classic header for recent searches and fix padding * apply suggestions from code review * docs(two-column-layout-example): add categories, brands and faq plugins (#910) * chore(two-columns-layout-example): add categories plugin * chore(two-columns-layout-example): add brands plugin * chore(two-columns-layout-example): add faq plugin * apply suggestions from code review * remove debug option * docs(two-column-layout-example): add articles and popular plugins (#911) * chore(two-columns-layout-example): add articles plugin * chore(two-columns-layout-example): add popular plugin * apply suggestions from code review * docs(two-column-layout-example): add reshape functions and quick access plugin (#912) * chore(two-columns-layout-example): add reshape functions * docs(two-columns-layout-example): add quick access plugin * chore: move reshape functions at file top-level * apply suggestions from code review * docs(two-column-layout-example): add smart preview feature (#913) * docs(two-columns-layout-example): add smart preview feature * docs(two-columns-layout-example): add faq article preview * apply suggestions from code review * docs(two-column-layout-example): add no results state and popular categories plugin (#914) * docs(two-columns-layout-example): add no results state and popular categories plugin * chore: fix empty div with Fragment * chore: fix empty div when no recent searches exist * chore: fix casing * apply suggestions from code review * apply suggestions from pair session * fix empty recent searches * fix linting * apply suggestion from code review * smart preview no longer depends on the DOM * apply suggestions from feedback * apply suggestions from feedback * apply suggestion from code review * apply suggestion from feedback
FabienMotte
added a commit
that referenced
this pull request
Mar 29, 2022
* docs(examples): scaffold two columns layout example * fix consistent naming * chore: fix linting * chore: fix styles * chore: fix deps * chore: add missing dep for Codesandbox * apply suggestions from code review * remove useless media queries * apply suggestions from code review * docs(two-column-layout-example): add products plugin (#909) * docs(two-columns-layout-example): add products plugin * apply suggestions from review * remove useless type * use classic header for recent searches and fix padding * apply suggestions from code review * docs(two-column-layout-example): add categories, brands and faq plugins (#910) * chore(two-columns-layout-example): add categories plugin * chore(two-columns-layout-example): add brands plugin * chore(two-columns-layout-example): add faq plugin * apply suggestions from code review * remove debug option * docs(two-column-layout-example): add articles and popular plugins (#911) * chore(two-columns-layout-example): add articles plugin * chore(two-columns-layout-example): add popular plugin * apply suggestions from code review * docs(two-column-layout-example): add reshape functions and quick access plugin (#912) * chore(two-columns-layout-example): add reshape functions * docs(two-columns-layout-example): add quick access plugin * chore: move reshape functions at file top-level * apply suggestions from code review * docs(two-column-layout-example): add smart preview feature (#913) * docs(two-columns-layout-example): add smart preview feature * docs(two-columns-layout-example): add faq article preview * apply suggestions from code review * docs(two-column-layout-example): add no results state and popular categories plugin (#914) * docs(two-columns-layout-example): add no results state and popular categories plugin * chore: fix empty div with Fragment * chore: fix empty div when no recent searches exist * chore: fix casing * apply suggestions from code review * apply suggestions from pair session * fix empty recent searches * fix linting * apply suggestion from code review * smart preview no longer depends on the DOM * apply suggestions from feedback * apply suggestions from feedback * apply suggestion from code review * apply suggestion from feedback * remove smart preview for now * add quick access selected transition * fix see all link margin * add getItemInputValue for faq * apply feedback * apply feedback * apply feedback * apply last fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the categories, brands and faq plugins to the Autocomplete two columns layout example.
Main PR: #908