-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(two-column-layout-example): add products plugin #909
docs(two-column-layout-example): add products plugin #909
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9384542:
|
6b57c2e
to
d988a02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed a few things in the UI:
- The title "Products" is very discreet. Why not use the header template from the theme?
- When there are less than 3 products, they fill the space, meaning they grow in height too. Couldn't we instead keep them at the same size?
- When images are loading, the space isn't "reserved" so there's layout shift. Also, with the blurhash we likely have three possible states: empty image, blurred image and crisp image instead of going from not loaded to loaded. Do we think it's good UX?
- When resizing the browser (large to narrow) there's a moment when the panel has a weird width (while resizing). It's particularly visible on Firefox. Is this caused by the custom CSS, or was it already there?
Another UI comment: I'm not a big fan of the color and styles for the star rating system, I find the blue a bit too "system" and it overpowers the rest. Here's a suggestion, wdyt? These are the colors we use for the star rating system on the docs' solutions. I also reduced the descriptive text and used a more muted color. |
d988a02
to
b3e72b0
Compare
Thanks for your comments! 🙏
It should be better like this. I removed the line at the end because the title is using a white background, conflicting with the background color on all products added by the smart preview feature.
Indeed, thanks!
When the image wasn't loaded, the body part was taking all the available height, hiding the Blurhash canvas. Now it should work properly. The blur placeholder is not an image, so it should be visible as the same time as the results. Screen.Recording.2022-03-08.at.18.43.11.mov
I think it is due to media queries that update the |
It's looking much better, thank you (and using one less SVG)! |
Regarding the blurash placeholder, it will only show once Algolia has responded (not visible in your video). Until then we don't have the hash so we need to display something. |
Is it possible that the state you mentioned is displayed at some point? I added a background color to the blurred |
47c2540
to
f26f445
Compare
|
f26f445
to
f2306a9
Compare
…ns (#910) * chore(two-columns-layout-example): add categories plugin * chore(two-columns-layout-example): add brands plugin * chore(two-columns-layout-example): add faq plugin * apply suggestions from code review * remove debug option * docs(two-column-layout-example): add articles and popular plugins (#911) * chore(two-columns-layout-example): add articles plugin * chore(two-columns-layout-example): add popular plugin * apply suggestions from code review * docs(two-column-layout-example): add reshape functions and quick access plugin (#912) * chore(two-columns-layout-example): add reshape functions * docs(two-columns-layout-example): add quick access plugin * chore: move reshape functions at file top-level * apply suggestions from code review * docs(two-column-layout-example): add smart preview feature (#913) * docs(two-columns-layout-example): add smart preview feature * docs(two-columns-layout-example): add faq article preview * apply suggestions from code review * docs(two-column-layout-example): add no results state and popular categories plugin (#914) * docs(two-columns-layout-example): add no results state and popular categories plugin * chore: fix empty div with Fragment * chore: fix empty div when no recent searches exist * chore: fix casing * apply suggestions from code review * apply suggestions from pair session * fix empty recent searches * fix linting * apply suggestion from code review * smart preview no longer depends on the DOM * apply suggestions from feedback * apply suggestions from feedback * apply suggestion from code review * apply suggestion from feedback
* docs(examples): scaffold two columns layout example * fix consistent naming * chore: fix linting * chore: fix styles * chore: fix deps * chore: add missing dep for Codesandbox * apply suggestions from code review * remove useless media queries * apply suggestions from code review * docs(two-column-layout-example): add products plugin (#909) * docs(two-columns-layout-example): add products plugin * apply suggestions from review * remove useless type * use classic header for recent searches and fix padding * apply suggestions from code review * docs(two-column-layout-example): add categories, brands and faq plugins (#910) * chore(two-columns-layout-example): add categories plugin * chore(two-columns-layout-example): add brands plugin * chore(two-columns-layout-example): add faq plugin * apply suggestions from code review * remove debug option * docs(two-column-layout-example): add articles and popular plugins (#911) * chore(two-columns-layout-example): add articles plugin * chore(two-columns-layout-example): add popular plugin * apply suggestions from code review * docs(two-column-layout-example): add reshape functions and quick access plugin (#912) * chore(two-columns-layout-example): add reshape functions * docs(two-columns-layout-example): add quick access plugin * chore: move reshape functions at file top-level * apply suggestions from code review * docs(two-column-layout-example): add smart preview feature (#913) * docs(two-columns-layout-example): add smart preview feature * docs(two-columns-layout-example): add faq article preview * apply suggestions from code review * docs(two-column-layout-example): add no results state and popular categories plugin (#914) * docs(two-columns-layout-example): add no results state and popular categories plugin * chore: fix empty div with Fragment * chore: fix empty div when no recent searches exist * chore: fix casing * apply suggestions from code review * apply suggestions from pair session * fix empty recent searches * fix linting * apply suggestion from code review * smart preview no longer depends on the DOM * apply suggestions from feedback * apply suggestions from feedback * apply suggestion from code review * apply suggestion from feedback * remove smart preview for now * add quick access selected transition * fix see all link margin * add getItemInputValue for faq * apply feedback * apply feedback * apply feedback * apply last fixes
This PR adds the products plugin to the Autocomplete two columns layout example.
Main PR: #908