-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: write "what is autocomplete"? #393
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 76ecdc3:
|
Co-authored-by: Sarah Dayan <[email protected]>
Thanks for the thorough review @sarahdayan !
I agree. I was originally thinking of adding the video I added to the internal autocomplete docs, but decided against it since it's not using this library. I'll create a new one for this purpose. |
Maybe @francoischalifour has a good looking demo we could use? |
For now we can use https://lkrug.csb.app which is the preview of the always-updated sandbox. |
Sounds good, I'll make a small video file. In an intro page, I think this is better than embedding a demo since it does everything for the user. In subsequent pages we can link/embed the demo itself. |
A video would be great but I think it's a little bit early since the API is still changing (I'm thinking about #381). What are you planning to address in the video? |
…ethod (#395) * Implements `empty` template and `renderEmpty` method * Add wait function to `test/utils` folder Co-authored-by: François Chalifour <[email protected]>
* feat(js): change renderer implementation to virtual DOM * feat(highlighting): revamp highlighting system to VDOM (#399)
Totally agree! Was actually just thinking of injecting the example into the getting started page after outlining it. What's the best way to do that in the context of Docusaurus? Just put in the markup container and include a separate script file to call? |
My guess would be using an |
We can wrap For now we can add placeholders, @yannickcr is working on a generic solution for that. |
Ah yes indeed, I forgot that Docusaurus supports MDX. So much better! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
886284c
to
d869f07
Compare
Hey @francoischalifour , since merging the latest I also used the super simple (even without highlighting) autocomplete example from "getting started" here. Is this what we were thinking, or should we somehow recreate the actual docsearch UX in this first introductory example? Also: I originally used |
@Meschreiber Sorry, I messed the merge with The example is what I had in mind. We'll rework the design later. |
@francoischalifour I’m still not sure what I’m messing up when using the I also get the error when using a non-typed function directly in the file without importing it. No issues in other guides where I'm not providing an item template. To reproduce, Any help greatly appreciated! Once this is set, I'd love to merge it and then use the same component in "Getting started". Thanks in advance! |
@Meschreiber In this guide, |
Thanks @francoischalifour , merging! |
This PR writes the first introduction page, "What is autocomplete".
It describes:
I feel like the second part is still a bit weak and could use some more technical details, so please suggest any you see missing. Thanks!