docs: write "what is autocomplete" #392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add recent-searches plugin * WIP * fix rollup error (peerDeps) * chore: exclude website from codesandbox ci builds * expose getRecentSearches * add getSources back * build only esm for codesandbox ci * add getSuggestions * remove peerDependency * renames * rename methods * resolve getSources from plugins too * call onSubmit and onSelect for plugins * update ci * Apply suggestions from code review Co-authored-by: François Chalifour <[email protected]> * add key to distinguish multiple stores of recent searches * early return * named export * apply feedbacks * wrap plugin specific methods with data * run onSubmit for plugins at getDefaultProps * Update packages/autocomplete-plugin-recent-searches/src/createRecentSearchesPlugin.ts Co-authored-by: François Chalifour <[email protected]> * add TData to plugins * forward onSelect plugin calls in getDefaultProps * Update packages/autocomplete-core/src/getDefaultProps.ts Co-authored-by: François Chalifour <[email protected]> * rename payload to params * add to store only when data exists * use query as a fallback for queryID * get input value from source * fix type errors Co-authored-by: François Chalifour <[email protected]>
* feat(recentSearches): add remove button * pass refresh to getSources * update styles * rename delete to remove and add title * remove return null * extract icon * update styles * bump the version * remove unecessary typing * wrap with a sub-container * export style
* test(js): use local version in assertion I think I needed this before lerna ran, but in either case, I think it makes more sense to assert the lcoal version is used than the one from @algolia/autocomplete-core * fix lint
* chore(ts): add MaybePromise wrapper to make APIs shorter to read * Update packages/autocomplete-js/src/types/index.ts
We won't support IE.
This introduces a brand new Autocomplete experience on touch devices (mobiles, tablets, etc.). This new experience is available via a media query so that it matches when it's triggered given your website requirements.
BREAKING CHANGE
Line 102 - removed the block wrapper to fix an "Unexpected block statement surrounding arrow body; move the returned value immediately after the `=>`" error. Line 102 - removed reference to index to fix the "'index' is already declared in the upper scope" and "'index' is defined but never used" errors.
* Fix special char escaping for highlighted recent searches
…m InstantSearch.js (#388) * Implement sibling strategy from InstantSearch.js * Increase bundle size * Rename `getHighlightFromSiblings` to `isPartHighlighted`
This can error if users return `undefined` instead of an empty string.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 27c8fdf:
|
|
Oops, this was a duplicate of #393. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR writes the first introduction page, "What is autocomplete".
It describes:
I feel like the second part is still a bit weak and could use some more technical details, so please suggest any you see missing. Thanks!