Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spec): add region for the Predict API #473

Merged
merged 5 commits into from
May 6, 2022
Merged

feat(spec): add region for the Predict API #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ccd30e7
fix(generator): add `hostWithFallback`
shortcuts May 6, 2022
1e72f35
format json
shortcuts May 6, 2022
a690c77
fix predict spec
shortcuts May 6, 2022
9d92566
feat(spec): add more regions to Predict API
anghelalexandra May 5, 2022
5d8edea
Merge branch 'main' into feat/predict-server-region
shortcuts May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/cts/client/generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ export async function generateClientTests(
).start();
const testsBlocks = await loadTests(client);

await createOutputDir({ language, testPath });

if (testsBlocks.length === 0) {
spinner.warn("skipping because tests doesn't exist");
return;
Expand All @@ -81,8 +83,6 @@ export async function generateClientTests(
verbose
).start();

await createOutputDir({ language, testPath });

const { suite: template, ...partialTemplates } = await loadTemplates({
language,
testPath,
Expand Down
2 changes: 1 addition & 1 deletion scripts/formatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export async function formatter(
let cmd = '';
switch (language) {
case 'javascript':
cmd = `yarn eslint --ext=ts ${folder} --fix`;
cmd = `yarn eslint --ext=ts ${folder} --fix --no-error-on-unmatched-pattern`;
break;
case 'java':
cmd = `find ${folder} -type f -name "*.java" | xargs java --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
Expand Down
1 change: 1 addition & 0 deletions specs/predict/spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ servers:
variables:
region:
enum:
- ue
- ew
default: ew
security:
Expand Down