Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spec): add region for the Predict API #473

Merged
merged 5 commits into from
May 6, 2022
Merged

feat(spec): add region for the Predict API #473

merged 5 commits into from
May 6, 2022

Conversation

anghelalexandra
Copy link
Contributor

🧭 What and Why

Predict API now has two separate endpoints for EU and US customers

🎟 JIRA Ticket:

Changes included:

  • Update servers in the Predict API spec

@anghelalexandra anghelalexandra requested a review from shortcuts May 5, 2022 10:52
@netlify
Copy link

netlify bot commented May 5, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 5d8edea
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6275236273631b00088f4a9b

@shortcuts
Copy link
Member

Thanks :D

We should wait for #471 to be merged as the server guessing for the codegen will change a bit

@algolia-bot
Copy link
Collaborator

algolia-bot commented May 5, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.

@shortcuts shortcuts changed the title Add region for the Predict API feat(spec): add region for the Predict API May 5, 2022
@anghelalexandra anghelalexandra marked this pull request as draft May 5, 2022 10:54
@shortcuts shortcuts force-pushed the feat/predict-server-region branch from 9fd842f to 5fd6225 Compare May 6, 2022 09:56
@shortcuts shortcuts changed the base branch from main to fix/generators-servers May 6, 2022 09:56
@shortcuts shortcuts mentioned this pull request May 6, 2022
Merged
@shortcuts shortcuts force-pushed the feat/predict-server-region branch from 5fd6225 to 3277fd1 Compare May 6, 2022 10:10
@shortcuts shortcuts force-pushed the feat/predict-server-region branch from 3277fd1 to 9d92566 Compare May 6, 2022 10:41
Base automatically changed from fix/generators-servers to main May 6, 2022 13:20
@shortcuts shortcuts marked this pull request as ready for review May 6, 2022 13:32
shortcuts
shortcuts approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@shortcuts shortcuts enabled auto-merge (squash) May 6, 2022 13:33
@shortcuts shortcuts merged commit 282d6b3 into main May 6, 2022
@shortcuts shortcuts deleted the feat/predict-server-region branch May 6, 2022 13:42
This was referenced May 19, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced May 25, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@millotp millotp millotp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anghelalexandra @shortcuts @algolia-bot @millotp