Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tooling): clients scripts and Docker image #43

Merged
merged 21 commits into from
Dec 17, 2021

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Dec 16, 2021

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

I had to create the Docker image since I did not wanted to install MVN etc. on my machine, I've took the base made by @millotp

  • Add clients script to build clients
  • Add Docker image with scripts and container
  • Update README.md
  • Update GA

🧪 Test

@shortcuts shortcuts marked this pull request as ready for review December 16, 2021 09:42
@shortcuts shortcuts requested review from a team and millotp and removed request for a team December 16, 2021 09:42
@shortcuts shortcuts self-assigned this Dec 16, 2021
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker ftw

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
scripts/clients.sh Outdated Show resolved Hide resolved
scripts/docker/build.sh Show resolved Hide resolved
scripts/docker/mount.sh Show resolved Hide resolved
scripts/docker/mount.sh Show resolved Hide resolved
scripts/multiplexer.sh Outdated Show resolved Hide resolved
scripts/post-gen/javascript.sh Show resolved Hide resolved
.dockerignore Show resolved Hide resolved
@shortcuts shortcuts force-pushed the chore/APIC-225/clients-script branch from 8f8fe12 to f51e16d Compare December 16, 2021 16:02
@shortcuts shortcuts requested a review from millotp December 16, 2021 16:08
"docker:clean": "docker stop dev; docker rm -f dev; docker image rm -f api-clients-automation",
"docker:mount": "./scripts/docker/mount.sh",
"docker:setup": "yarn docker:clean && yarn docker:build && yarn docker:mount",
"docker": "docker exec dev yarn $*",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to pass the signals too ? Like ctrl+c is not stopping the generation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not managed to reproduce, I'm able to use ctrl+c on my side 🤔

scripts/post-gen/java.sh Show resolved Hide resolved
damcou
damcou previously approved these changes Dec 17, 2021
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great :)

Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants