feat: add multiclusters endpoints for the search client #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you merge |
MaxenceMaire
changed the title
MaxenceMaire
commented
Dec 13, 2021
shortcuts
reviewed
Dec 13, 2021
clients/algoliasearch-client-javascript/client-search/model/inlineResponse200.ts
Outdated
Show resolved
Hide resolved
clients/algoliasearch-client-javascript/client-search/model/listClustersReponse.ts
Outdated
Show resolved
Hide resolved
clients/algoliasearch-client-javascript/client-search/model/listUserIdsResponse.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Clément Vannicatte <[email protected]>
Co-authored-by: Clément Vannicatte <[email protected]>
millotp
reviewed
Dec 14, 2021
millotp
reviewed
Dec 14, 2021
clients/algoliasearch-client-javascript/client-search/model/inlineObject.ts
Outdated
Show resolved
Hide resolved
shortcuts
reviewed
Dec 16, 2021
Comment on lines
4
to
5
| userID?: HighlightResult; | ||
| clusterName?: HighlightResult; |
There was a problem hiding this comment.
I don't think we can add a description since they are defined like so:
properties:
userID:
$ref: '../../common/schemas/Record.yml#/highlightResult'
clusterName:
$ref: '../../common/schemas/Record.yml#/highlightResult'
Sibling elements of $ref are ignored: https://swagger.io/docs/specification/using-ref/#sibling
Also the original documentation doesn't seem to have a description for those: https://www.algolia.com/doc/api-reference/api-methods/search-user-id/#method-response-_highlightresult-object
What do you think?
| * List of user object matching the query. | ||
| */ | ||
| hits: SearchUserIdsResponseHits[]; | ||
| nbHits: Record<string, any>; |
There was a problem hiding this comment.
Same as above, sibling elements of $ref are ignored so I'm not sure how to add a description here?
| @@ -1,3 +0,0 @@ | |||
| export type SearchParamsAsString = { | |||
clients/algoliasearch-client-java-2/algoliasearch-core/com/algolia/model/SynonymHit.java
Outdated
Show resolved
Hide resolved
…cription to highlightResult object
…golia/api-clients-automation into feat/APIC-195/multiclusters-endpoints
millotp
approved these changes
Dec 16, 2021
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added multiclusters endpoints for the search client:
POST /1/clusters/mappingGET /1/clusters/mappingDELETE /1/clusters/mappingPOST /1/clusters/mapping/batchGET /1/clusters/mapping/topGET /1/clusters/mapping/{userID}GET /1/clustersPOST /1/clusters/mapping/searchGET /1/clusters/mapping/pendingRelated doc :