chore(ci): parse commits correctly #294
Conversation
✅ Deploy Preview for api-clients-automation canceled.
|
eunjae-lee
requested review from
a team,
damcou and
shortcuts
and removed request for
a team
| let message = commit.slice(8); | ||
| const LENGTH_SHA1 = 8; | ||
| const hash = commit.slice(0, LENGTH_SHA1); | ||
| let message = commit.slice(LENGTH_SHA1 + 1); |
There was a problem hiding this comment.
For the code just below, the CI allows empty scope for chores and docs, it will trigger the error line 68 I think.
Either we always enforce scope or you check here for the type first.
There was a problem hiding this comment.
You're right, but chore and docs commit don't affect versioning. So it's okay to ignore them. It returns { error: '...' } but later the script just prints out the warning messages. (We are planning to include these ignored commits within the release issue in a separate PR)
What do you think?
There was a problem hiding this comment.
Oh sorry I didn't see the rest of the code, all good then
There was a problem hiding this comment.
No worries. Thanks for the comment!
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
force-pushed
the
chore/commit-sha
branch
from
9944673 to
6940b74
Compare
* chore(ci): parse commits correctly * Update create-release-issue.test.ts
🧭 What and Why
Changes included:
git log --onelinegives SHA1 in 8 length. Previously the code and the test were written, assuming it was 7, which was wrong.🧪 Test
CI