chore(ci): parse commits correctly (#294)

* chore(ci): parse commits correctly * Update create-release-issue.test.ts
algolia · Mar 25, 2022 · 7f0fcae · 7f0fcae
1 parent 8650fe4
commit 7f0fcae
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 17 deletions.
diff --git a/scripts/release/__tests__/create-release-issue.test.ts b/scripts/release/__tests__/create-release-issue.test.ts
@@ -17,23 +17,23 @@ describe('create release issue', () => {
   });
 
   it('parses commit', () => {
-    expect(parseCommit(`abcdefg fix(javascript): fix the thing`)).toEqual({
-      hash: 'abcdefg',
+    expect(parseCommit(`b2501882 fix(javascript): fix the thing`)).toEqual({
+      hash: 'b2501882',
       lang: 'javascript',
       message: 'fix the thing',
-      raw: 'abcdefg fix(javascript): fix the thing',
+      raw: 'b2501882 fix(javascript): fix the thing',
       type: 'fix',
     });
   });
 
   it('returns error when language scope is missing', () => {
-    expect(parseCommit(`abcdefg fix: fix the thing`)).toEqual({
+    expect(parseCommit(`b2501882 fix: fix the thing`)).toEqual({
       error: 'missing-language-scope',
     });
   });
 
   it('returns error when language scope is unknown', () => {
-    expect(parseCommit(`abcdefg fix(basic): fix the thing`)).toEqual({
+    expect(parseCommit(`b2501882 fix(basic): fix the thing`)).toEqual({
       error: 'unknown-language-scope',
     });
   });
@@ -125,11 +125,11 @@ describe('create release issue', () => {
       },
       commits: [
         {
-          hash: 'abcdefg',
+          hash: 'b2501882',
           type: 'feat',
           lang: 'javascript',
           message: 'update the API (BREAKING CHANGE)',
-          raw: 'abcdefg feat(javascript): update the API (BREAKING CHANGE)',
+          raw: 'b2501882 feat(javascript): update the API (BREAKING CHANGE)',
         },
       ],
     });
@@ -152,11 +152,11 @@ describe('create release issue', () => {
       },
       commits: [
         {
-          hash: 'abcdefg',
+          hash: 'b2501882',
           type: 'feat',
           lang: 'php',
           message: 'update the API',
-          raw: 'abcdefg feat(php): update the API',
+          raw: 'b2501882 feat(php): update the API',
         },
       ],
     });
@@ -179,11 +179,11 @@ describe('create release issue', () => {
       },
       commits: [
         {
-          hash: 'abcdefg',
+          hash: 'b2501882',
           type: 'fix',
           lang: 'java',
           message: 'fix some bug',
-          raw: 'abcdefg fix(java): fix some bug',
+          raw: 'b2501882 fix(java): fix some bug',
         },
       ],
     });
@@ -206,11 +206,11 @@ describe('create release issue', () => {
       },
       commits: [
         {
-          hash: 'abcdefg',
+          hash: 'b2501882',
           type: 'fix',
           lang: 'java',
           message: 'fix some bug',
-          raw: 'abcdefg fix(java): fix some bug',
+          raw: 'b2501882 fix(java): fix some bug',
         },
       ],
     });
@@ -235,11 +235,11 @@ describe('create release issue', () => {
       },
       commits: [
         {
-          hash: 'abcdefg',
+          hash: 'b2501882',
           type: 'chore',
           lang: 'javascript',
           message: 'update devDevpendencies',
-          raw: 'abcdefg chore(javascript): update devDevpendencies',
+          raw: 'b2501882 chore(javascript): update devDevpendencies',
         },
       ],
     });

diff --git a/scripts/release/create-release-issue.ts b/scripts/release/create-release-issue.ts
@@ -58,8 +58,9 @@ export function getVersionChangesText(versions: Versions): string {
 }
 
 export function parseCommit(commit: string): Commit {
-  const hash = commit.slice(0, 7);
-  let message = commit.slice(8);
+  const LENGTH_SHA1 = 8;
+  const hash = commit.slice(0, LENGTH_SHA1);
+  let message = commit.slice(LENGTH_SHA1 + 1);
   let type = message.slice(0, message.indexOf(':'));
   const matchResult = type.match(/(.+)\((.+)\)/);
   if (!matchResult) {