feat(cts): use custom package to fix openapi-generator-cli #254
Conversation
|
✔️ Deploy Preview for api-clients-automation canceled. 🔨 Explore the source changes: d3e32ac 🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/6232f8865b2960000996ca3c |
millotp
requested review from
a team,
eunjae-lee and
shortcuts
and removed request for
a team
| { text: 'generating requests tests', indent: 4 }, | ||
| verbose | ||
| ).start(); | ||
| await run( |
There was a problem hiding this comment.
Can you explain to me why we pass this custom generator regardless of gen.language? IIUC, we should pass for java only, no?
There was a problem hiding this comment.
It generate the same mustache bundle as the ts generator, only with more data on types, so it can be used to generate js tests also, we don't need the duplicate code.
The js tests are generated with this custom generator and it produces no diff.
| case 'javascript': | ||
| await generateRequestsTests(generator, verbose); |
There was a problem hiding this comment.
Are we removing generateRequestsTests?
There was a problem hiding this comment.
They are still generated from the CTS custom generator, written in java but not specific to java
There was a problem hiding this comment.
Thanks for the explanation. I missed that part.
|
✗ The generated branch has been deleted. If the PR has been merged, you can check the generated code on the |
🧭 What and Why
Fixed a bug in openapi-generator-cli and deployed custom package with the fixed waiting for the PR to be merged.
Also removes every custom code used for CTS generation, and exclusively use the Java one (remove the ts one), as they generate the same code now.
Changes included:
🧪 Test
CI