Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#439): allow custom generator to be passed to the generate command #620

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

millotp
Copy link
Contributor

@millotp millotp commented Mar 15, 2022

Fixes #439

The custom-generator parameter was only working for simple passthrough command, passing custom-generator to the generate command allows it to be used alongside -generator-key parameters.

@kay-schecker kay-schecker changed the title fix: allow custom generator to be passed to the generate command fix(#439): allow custom generator to be passed to the generate command Mar 17, 2022
@kay-schecker
Copy link
Contributor

Thanks for the PR :) What about the unit tests?

@millotp millotp reopened this Mar 21, 2022
@millotp
Copy link
Contributor Author

millotp commented Mar 22, 2022

Sorry for the rebasing mess, I've added tests to the pass-though and generator command :)

@millotp
Copy link
Contributor Author

millotp commented Apr 15, 2022

Hello, can I get an update on this ?

@kay-schecker kay-schecker merged commit 3089895 into OpenAPITools:master Apr 15, 2022
@github-actions
Copy link

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Custom generator not being recognized by CLI
2 participants