forked from dotnet/fsharp
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ref assembly output part1 #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions and ones without
… the compiler understands Accessibility.
This reverts commit a847a71.
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Add `WarningsNotAsErrors` to be forwarded to the compiler
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…126.2 (dotnet#12459) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21574.3 -> To Version 7.0.0-beta.21576.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
… Build ID 1487500 (dotnet#12461) * Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1487500 * Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 1487500
…126.4 (dotnet#12462) Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21576.2 -> To Version 7.0.0-beta.21576.4 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…& SynModuleSigDecl.Exception. (dotnet#12441)
… Build ID 1489251 (dotnet#12468)
* Allow IsByRefLikeAttribute to be specified in user code or a non-framework assembly. And use isByrefLikeTyconRef instead of specifically checking whether the attribute is applied. A post-inference check about this attribute was moved to the aforementioned function. * Fix a typo. * Remove some leftover code that was causing errors. And use tname_IsByRefLikeAttribute without the TcGlobals qualification. * Handle the ILTypeSpec.Enclosing property correctly. It wasn't holding the namespace's components but the inner types if it was nested. The project now builds. * Test that custom IsByRefLikeAttributes are recognized. * Fix one failing test. * Fix another failing test. * Address PR feedback: move a check back to PostInferenceChecks.fs. * Add another test.
Co-authored-by: Will Smith <[email protected]>
… Build ID 1499018 (dotnet#12492)
* Update dependencies from https://github.com/dotnet/arcade build 20211202.3 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21576.4 -> To Version 7.0.0-beta.21602.3 * Update dependencies from https://github.com/dotnet/arcade build 20211203.6 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21576.4 -> To Version 7.0.0-beta.21603.6 * Update dependencies from https://github.com/dotnet/arcade build 20211206.6 Microsoft.DotNet.Arcade.Sdk From Version 7.0.0-beta.21576.4 -> To Version 7.0.0-beta.21606.6 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…visualfsharp into ref-assembly-output-part1
…, until MVID generation is fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dotnet#12334