Fix Travis CI build errors. Closes #1224 #1255
Merged
+11
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1224. There were a few main causes:
pg
gem released a new 1.0.0 version yesterday which caused issues with Rails versions < 5 requiring~> 0.11
at runtime, and Rails 5 requiring~> 0.18
(figuring this out was slightly complicated by rake_test_loader swallowed a load error ruby/rake#247)activerecord-jdbc-adapter
gem released version 50.0 semi-recently, which should only be used by Rails 5+Also, I don't know whether the intention is for the Gemfile in the root of the project to run agains the latest version of Rails or not, but
mongoid
being pinned to 2.6.0 is forcing it to select Rails 3, which is why I had to apply the version restriction onactiverecord-jdbcpostgresql-adapter
there to get the tests to pass.