Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis CI build errors. Closes #1224 #1255

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

abevoelker
Copy link
Contributor

Closes #1224. There were a few main causes:

Also, I don't know whether the intention is for the Gemfile in the root of the project to run agains the latest version of Rails or not, but mongoid being pinned to 2.6.0 is forcing it to select Rails 3, which is why I had to apply the version restriction on activerecord-jdbcpostgresql-adapter there to get the tests to pass.

@alexreisner
Copy link
Owner

Thanks for this! Really glad to have the tests fixed. Also you bring up a good point about Mongoid being pinned to 2.6.0. That was for Ruby 1.8 compatibility, which has since been dropped. So we don't need to pin it anymore. You want to fix that too?

@abevoelker
Copy link
Contributor Author

Sure; I tested that change in a separate branch, however that surfaced one new build error which will require a new version of the activerecord-jdbcpostgresql-adapter to be published: jruby/activerecord-jdbc-adapter#780 (comment)

The build error could probably be worked around right now by changing the Gemfile to use the GitHub source instead:

gem 'activerecord-jdbcpostgresql-adapter', github: 'jruby/activerecord-jdbc-adapter'

But rather'n dirtying up the Gemfile it's probably preferable to just wait for the new gem version to be cut.

@alexreisner
Copy link
Owner

What about locking mongoid and activerecord-jdbcpostgresql-adapter so the most recent combo that works? I misspoke when I said we don't need to pin it at all--if we don't, the build constantly breaks (as illustrated). (Sorry!)

@abevoelker
Copy link
Contributor Author

No preference here, it's your show 😄

Unfortunately I can't put more time on this PR; I'll have to bow out now as I've ran out of personal time. I leave it in your (or someone else's) capable hands to tidy up the Gemfile to your liking ✌️

@alexreisner
Copy link
Owner

Sounds good--I'll finish this up. Appreciate the help!

@alexreisner alexreisner merged commit 82687a2 into alexreisner:master Jan 11, 2018
kobsy added a commit to cph/abstract_importer that referenced this pull request Jan 23, 2018
zacviandier pushed a commit to teezily/geocoder that referenced this pull request Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Travis Tests failing
2 participants