-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis Tests failing #1224
Comments
Issues in the build:
|
Found out that a bunch of older versions of Ruby are no longer supported. Updating our travis test matrix to reflect that: #1225 |
We also should update our travis to work with newer versions of jruby: https://github.com/jruby/jruby/wiki/Roadmap |
Okay. That makes sense. Let’s revert #1225 for now then and continue to
talk about what we should do.
…On Mon, Sep 25, 2017 at 18:22 Alex Reisner ***@***.***> wrote:
Hmm...I don't think we should do this quite so suddenly. "Unsupported"
Ruby versions aren't dead, they're just not receiving security updates.
They may still be in (wide) use, and removing versions from the test matrix
is tantamount to dropping support for them, which requires a minor version
bump, and so should probably be merged into a separate branch (eg, 1.5.0).
I think we can drop 1.9.3 support in the next minor release, and I'm open
to arguments for dropping 2.0.x support as well, although I'm a little less
comfortable with that, given that compatibility and ease of use are core
Geocoder features. For the others, we should introduce version-specific
gemfiles and select compatible versions of gems (eg, byebug).
And, when we do drop 1.9.3 support, we can also remove
gemfiles/Gemfile.ruby1.9.3. Yay!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1224 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACBOwWg85d9kAKwYhuEeq2JqysRStpmBks5smFHJgaJpZM4PjbXp>
.
|
Yes! Thanks for raising this issue. We need to fix the tests as it makes contributing more confusing. |
@TrangPham I agree: let's drop 1.9.3 support. If you want to go ahead and do it, just make the commit in a |
I've reverted #1225 from master for now. I will continue to look at the travis tests soon |
Fix Travis CI build errors. Closes #1224
Fix Travis CI build errors. Closes alexreisner#1224
Travis tests are failing for some of the builds in matrix due to gem dependency issues causing bundle install not to complete correctly See: https://travis-ci.org/alexreisner/geocoder/builds/277296105
The text was updated successfully, but these errors were encountered: