Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis Tests failing #1224

Closed
TrangPham opened this issue Sep 25, 2017 · 7 comments · Fixed by #1255
Closed

Travis Tests failing #1224

TrangPham opened this issue Sep 25, 2017 · 7 comments · Fixed by #1255

Comments

@TrangPham
Copy link
Contributor

Travis tests are failing for some of the builds in matrix due to gem dependency issues causing bundle install not to complete correctly See: https://travis-ci.org/alexreisner/geocoder/builds/277296105

@TrangPham
Copy link
Contributor Author

Issues in the build:
An error occurred while installing byebug (9.1.0), and Bundler cannot continue.

  • 2.1.2

The program 'bundle' is currently not installed. To run 'bundle' please ask your administrator to install the package 'bundler'

  • jruby-19mode

@TrangPham
Copy link
Contributor Author

Found out that a bunch of older versions of Ruby are no longer supported. Updating our travis test matrix to reflect that: #1225

@TrangPham
Copy link
Contributor Author

We also should update our travis to work with newer versions of jruby: https://github.com/jruby/jruby/wiki/Roadmap

@TrangPham
Copy link
Contributor Author

TrangPham commented Sep 26, 2017 via email

@alexreisner
Copy link
Owner

Yes! Thanks for raising this issue. We need to fix the tests as it makes contributing more confusing.

@alexreisner
Copy link
Owner

@TrangPham I agree: let's drop 1.9.3 support. If you want to go ahead and do it, just make the commit in a 1.5.0 branch, in case we need to do another release before we get 1.5.0 polished.

@TrangPham
Copy link
Contributor Author

I've reverted #1225 from master for now. I will continue to look at the travis tests soon

alexreisner added a commit that referenced this issue Jan 11, 2018
Fix Travis CI build errors. Closes #1224
zacviandier pushed a commit to teezily/geocoder that referenced this issue Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants