Skip to content

Commit

Permalink
Remove mobile/compare page and references (mozilla#14168)
Browse files Browse the repository at this point in the history
* removed mobile compare page and references

* removed decomissioned compare bundles
  • Loading branch information
reemhamz authored Feb 5, 2024
1 parent 88b4478 commit 91a371a
Show file tree
Hide file tree
Showing 17 changed files with 17 additions and 764 deletions.
26 changes: 0 additions & 26 deletions bedrock/base/templates/includes/banners/mobile/mobile-compare.html

This file was deleted.

2 changes: 2 additions & 0 deletions bedrock/firefox/redirects.py
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,8 @@ def firefox_channel(*args, **kwargs):
# bug 1418500
redirect(r"^firefox/android/?$", "firefox.browsers.mobile.android"),
redirect(r"^firefox/focus/?$", "firefox.browsers.mobile.focus"),
# issue 14141
redirect(r"^firefox/browsers/mobile/compare/?$", "firefox.browsers.mobile.index"),
redirect(r"^firefox/ios/?$", "firefox.browsers.mobile.ios"),
# issue 9502
redirect(r"^firefox/quantum/?", "/firefox/browsers/quantum/"),
Expand Down
6 changes: 0 additions & 6 deletions bedrock/firefox/templates/firefox/browsers/compare/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,12 @@
{% block page_css %}
{{ css_bundle('protocol-split') }}
{{ css_bundle('compare') }}
{{ css_bundle('mobile-compare-banner') }}
{% endblock %}

{% block sub_navigation %}
{% include 'firefox/browsers/compare/includes/subnav.html' %}
{% endblock %}

{% block page_banner %}
{% include 'includes/banners/mobile/mobile-compare.html' %}
{% endblock %}

{% block content %}
{% call split(
image=resp_img(
Expand Down Expand Up @@ -401,5 +396,4 @@ <h3>{{ ftl('compare-index-firefox-is-backed-by-the-not') }}</h3>

{% block js %}
{{ js_bundle('sticky_promo') }}
{{ js_bundle('mobile_compare_banner') }}
{% endblock %}
412 changes: 0 additions & 412 deletions bedrock/firefox/templates/firefox/browsers/mobile/compare.html

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,5 @@
'text': ftl('sub-navigation-firefox-focus'),
'href': url('firefox.browsers.mobile.focus'),
'cta_name': "Firefox Focus"
},
{
'text': ftl('sub-navigation-chromebook'),
'href': url('firefox.browsers.chromebook'),
'cta_name': "Chromebook"
},
{
'text': ftl('sub-navigation-compare-mobile-browsers'),
'href': url('firefox.browsers.mobile.compare'),
'cta_name': "Compare Mobile Browsers"
}]
) }}
36 changes: 13 additions & 23 deletions bedrock/firefox/templates/firefox/browsers/mobile/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -141,29 +141,19 @@ <h3 class="mzp-c-menu-list-title">{{ ftl('browsers-mobile-download') }}</h3>
<p><a class="mzp-c-cta-link" href="{{ url('firefox.browsers.mobile.focus') }}" data-cta-type="link" data-cta-text="Focus Learn More">{{ ftl('ui-learn-more') }}</a></p>
</div>

<div class="c-landing-grid-item">
<img src="{{ static('img/firefox/browsers/mobile/index/compare-mobile-browsers.svg') }}" alt="" class="c-landing-grid-img" width="350" height="350">
<h2 class="c-landing-grid-title">
<a href="{{ url('firefox.browsers.mobile.compare') }}" data-cta-type="link" data-cta-text="Compare Mobile Browsers">{{ ftl('browsers-mobile-compare-mobile-browsers') }}</a>
</h2>
<p>{{ ftl('browsers-mobile-see-how-firefox-stacks-up') }}</p>

<p><a class="mzp-c-cta-link" href="{{ url('firefox.browsers.mobile.compare') }}" data-cta-type="link" data-cta-text="Compare">{{ ftl('browsers-mobile-compare') }}</a></p>
</div>

<div class="c-landing-grid-item c-landing-grid-wide">
{% call split(
image=resp_img('img/firefox/browsers/dev.png',
srcset={ 'img/firefox/browsers/dev-high-res.png': '2x' },
optional_attributes={ 'class': 'mzp-c-split-media-asset'}
),
block_class='t-compare'
) %}
<h2>{{ ftl('browsers-mobile-see-how-firefox-for-desktop-compare') }}</h2>
<p class="c-compare-title mzp-has-zap-06">{{ ftl('browsers-mobile-see-how-firefox-for-desktop-strong') }}</p>
<p><a class="mzp-c-cta-link" href="{{ url('firefox.browsers.compare.index') }}" data-cta-type="link" data-cta-text="Compare">{{ ftl('browsers-mobile-compare') }}</a></p>
{% endcall %}
</div>
</section>
<section class="c-browser-compare mzp-l-content mzp-t-content-lg">
{% call split(
image=resp_img('img/firefox/browsers/dev.png',
srcset={ 'img/firefox/browsers/dev-high-res.png': '2x' },
optional_attributes={ 'class': 'mzp-c-split-media-asset'}
),
block_class='t-compare'
) %}
<h2>{{ ftl('browsers-mobile-see-how-firefox-for-desktop-compare') }}</h2>
<p class="c-compare-title mzp-has-zap-06">{{ ftl('browsers-mobile-see-how-firefox-for-desktop-strong') }}</p>
<p><a class="mzp-c-cta-link" href="{{ url('firefox.browsers.compare.index') }}" data-cta-type="link" data-cta-text="Compare">{{ ftl('browsers-mobile-compare') }}</a></p>
{% endcall %}
</section>

{% include 'mozorg/includes/mozilla-account-form-promo.html' %}
Expand Down
5 changes: 0 additions & 5 deletions bedrock/firefox/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,11 +195,6 @@
page("firefox/browsers/mobile/ios/", "firefox/browsers/mobile/ios.html", ftl_files=["firefox/browsers/mobile/ios"]),
page("firefox/browsers/mobile/get-ios/", "firefox/browsers/mobile/get-ios.html", ftl_files=["firefox/browsers/mobile/get-ios"]),
page("firefox/browsers/mobile/focus/", "firefox/browsers/mobile/focus.html", ftl_files=["firefox/browsers/mobile/focus"]),
page(
"firefox/browsers/mobile/compare/",
"firefox/browsers/mobile/compare.html",
ftl_files=["firefox/browsers/mobile/compare", "firefox/browsers/compare/shared"],
),
page("firefox/browsers/mobile/get-app/", "firefox/browsers/mobile/get-app.html", ftl_files=["firefox/mobile"]),
# Issue 8641
page("firefox/browsers/best-browser/", "firefox/browsers/best-browser.html", ftl_files=["firefox/browsers/best-browser"]),
Expand Down
3 changes: 0 additions & 3 deletions l10n/en/firefox/browsers/compare/index.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,3 @@ compare-index-browsers-have-come-a-long = Browsers have come a long way since {
compare-index-firefox-is-backed-by-the-not = { -brand-name-firefox } is backed by the not-for-profit { -brand-name-mozilla }.
compare-index-firefox-puts-your-privacy = { -brand-name-firefox } puts your privacy first — in everything we make and do. We believe you have the right to decide how and with whom you share your personal information. { -brand-name-firefox } collects as little data as possible and never sells it. The little data we do collect is only used to make products and features better. No secrets. But a lot of transparency and real privacy.
compare-index-based-on-the-criteria-we-outlined = Based on the criteria we outlined — privacy, utility, and portability — there’s really only one browser that meets the mark, and that’s { -brand-name-firefox }. The real area of difference isn’t in functionality, it’s privacy. { -brand-name-firefox } is the most private browser that doesn’t lock you into an ecosystem. Use it on any operating system, on all your devices, and feel secure when you do.
compare-index-see-how-firefox-for-mobile = See how { -brand-name-firefox } for mobile stacks up to five other mobile browsers.
compare-index-compare = Compare
64 changes: 0 additions & 64 deletions l10n/en/firefox/browsers/mobile/compare.ftl

This file was deleted.

2 changes: 0 additions & 2 deletions l10n/en/firefox/browsers/mobile/index.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ browsers-mobile-the-more-you-use = The more you use it, the smarter it gets. { -
browsers-mobile-get-enhanced-tracking-protection = Get Enhanced Tracking Protection and make { -brand-name-firefox } your default, go-to, forever browser on your { -brand-name-iphone } and { -brand-name-ipad }.
browsers-mobile-firefox-focus = { -brand-name-firefox-focus }
browsers-mobile-looking-for-a-streamlined = Looking for a streamlined, super fast mobile browser with next-level privacy features? { -brand-name-firefox-focus } automatically erases all your browsing history from the moment you open your browser to the second you close it.
browsers-mobile-compare-mobile-browsers = Compare Mobile Browsers
browsers-mobile-see-how-firefox-stacks-up = See how { -brand-name-firefox } stacks up against other popular browsers when it comes to the big three: privacy, features and syncing.
browsers-mobile-compare = Compare
browsers-mobile-see-how-firefox-for-desktop-stacks = See how { -brand-name-firefox } for desktop stacks up to seven other browsers.
Expand Down
97 changes: 0 additions & 97 deletions media/css/base/banners/mobile-compare.scss

This file was deleted.

8 changes: 0 additions & 8 deletions media/css/firefox/browsers-products.scss
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,6 @@ main .mzp-l-content {
clear: left;
margin-left: 0;
}

&.c-landing-grid-wide {
width: 100%;
}
}
}

Expand Down Expand Up @@ -226,10 +222,6 @@ main .mzp-l-content {
.c-landing-grid-img {
max-width: 100%;
}

.c-landing-grid-wide {
grid-column: span 2;
}
}

// three column
Expand Down
Loading

0 comments on commit 91a371a

Please sign in to comment.