Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mobile/compare page and references #14168

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

reemhamz
Copy link
Contributor

@reemhamz reemhamz commented Feb 1, 2024

One-line summary

The mobile compare page is out-of-date, and we've decided to remove the page alongside any references and assets

Significant changes and points to review

  • Removed browsers/mobile/compare page and browsers/mobile/compare.ftl file
  • Removed browsers/mobile/compare page reference in browsers/mobile
  • Removed banner on firefox/browsers/compare page
  • Removed assets and links leading to the page
  • Redirected the browsers/mobile/compare page to browsers/mobile landing page

Issue / Bugzilla link

#14141

Testing

@reemhamz reemhamz force-pushed the remove-mobile-compare-pages branch from 0c36519 to 2516b6a Compare February 1, 2024 05:02
@reemhamz reemhamz added Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Feb 1, 2024
@reemhamz reemhamz force-pushed the remove-mobile-compare-pages branch from 2516b6a to d6c8123 Compare February 2, 2024 03:16
Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of loose ends that can also be removed, but otherwise this looks good to me. r+wc 📞

@alexgibson alexgibson removed the Needs Review Awaiting code review label Feb 2, 2024
@reemhamz reemhamz merged commit 91a371a into mozilla:main Feb 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants