-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output of GX/GN in non-solo runs #1190
Comments
Hi David, I was struggling with this issue for a few releases - could you please try 2.7.8a? Cheers |
This was in 2.7.8a, actually |
Hi David, you are right, this is still not working. Will fix it shortly. Cheers |
I just want to add this doesn't seem to work with CB_samTagOut parameter set, although looking at the source code it looks like it was intended. Would it be possible to add the parameter to add the GX/GN tag w/o quantification? As well as allowing it with the GeneFull parameter? |
Hi Chang, GX/GN should now work for GeneFull in release 2.7.9, and even non-solo runs. I will check what's going on with CB_samTagOut. Cheers |
I think the issue is in ParametersSolo.cpp line 218. I ended up removing the outer if statement and works for me. STAR/source/ParametersSolo.cpp Line 218 in ac39348
|
Hi Chang, you are right, removing this condition should make it work. I think there should be no issues, but I need to test it. Cheers |
The release notes for 2.7.6 note that GX/GN can be output for all runs, however I just tried a run of the form:
And the resulting BAM file does not contain these. Is there an argument that I'm missing?
(The fixed was referenced in #945)
The text was updated successfully, but these errors were encountered: