-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes a lot of the errors raised by ruff #275
base: master
Are you sure you want to change the base?
Conversation
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
f21f138
to
050c9e5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 38.56% 38.31% -0.25%
==========================================
Files 18 18
Lines 1932 1939 +7
Branches 335 335
==========================================
- Hits 745 743 -2
- Misses 1151 1160 +9
Partials 36 36 ☔ View full report in Codecov by Sentry. |
@@ -695,17 +709,17 @@ async def list( | |||
echo(messages.json(indent=4)) | |||
else: | |||
# Since we filtered on message type, we can safely cast as InstanceMessage. | |||
messages = cast(List[InstanceMessage], messages) | |||
messages = cast(builtins.list[InstanceMessage], messages) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we should not update filter_only_valid_messages
to use generics 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's in the scope of this PR? We probably want to use Sequence
instead of list
for it as a type anyway
050c9e5
to
012d9e5
Compare
012d9e5
to
54cbee7
Compare
@hoh what version of python do we target? Right now it's stucked on 3.9 and some new notation aren't supported, I want to know if I need to revert them. |
Ruff isn't running on this project for various reason and it raises a LOT of errors.
This PR fixes a good part of the errors but not all of them but all this improvements can already be merged so we can benefit from it.
Related ClickUp, GitHub or Jira tickets : ALEPH-127
Self proofreading checklist