Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ruff #276

Merged
merged 19 commits into from
Feb 11, 2025
Merged

Enable ruff #276

merged 19 commits into from
Feb 11, 2025

Conversation

Psycojoker
Copy link
Collaborator

@Psycojoker Psycojoker commented Sep 25, 2024

Appart from the weird compilation bug on ubuntu 20.04, the CI failures seems to be already present on master.

ALEPH-175

@Psycojoker Psycojoker changed the base branch from master to lp-fix-most-ruff-errors September 25, 2024 19:13
@Psycojoker Psycojoker force-pushed the lp-fix-most-ruff-errors branch from f21f138 to 050c9e5 Compare September 25, 2024 19:35
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 54.96689% with 68 lines in your changes missing coverage. Please review.

Project coverage is 57.14%. Comparing base (ba35b91) to head (12d3e8d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/aleph_client/commands/program.py 64.70% 18 Missing ⚠️
src/aleph_client/commands/instance/__init__.py 30.43% 16 Missing ⚠️
src/aleph_client/commands/utils.py 43.75% 9 Missing ⚠️
src/aleph_client/commands/message.py 20.00% 8 Missing ⚠️
src/aleph_client/utils.py 72.22% 5 Missing ⚠️
src/aleph_client/commands/aggregate.py 33.33% 3 Missing and 1 partial ⚠️
src/aleph_client/__init__.py 0.00% 2 Missing ⚠️
src/aleph_client/commands/account.py 50.00% 2 Missing ⚠️
src/aleph_client/commands/domain.py 60.00% 2 Missing ⚠️
src/aleph_client/commands/instance/display.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   57.29%   57.14%   -0.15%     
==========================================
  Files          18       18              
  Lines        2763     2779      +16     
  Branches      377      377              
==========================================
+ Hits         1583     1588       +5     
- Misses        972      983      +11     
  Partials      208      208              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Psycojoker Psycojoker force-pushed the lp-fix-most-ruff-errors branch from 050c9e5 to 012d9e5 Compare September 27, 2024 21:50
@Psycojoker Psycojoker force-pushed the lp-fix-most-ruff-errors branch from 012d9e5 to 54cbee7 Compare October 3, 2024 00:09
@Psycojoker Psycojoker force-pushed the lp-ruff branch 2 times, most recently from ba09be7 to 4344abc Compare January 17, 2025 05:01
@Psycojoker Psycojoker changed the base branch from lp-fix-most-ruff-errors to master January 17, 2025 05:16
@Psycojoker
Copy link
Collaborator Author

Appart from the weird compilation bug on ubuntu 20.04, the CI failures seems to be already present on master.

@Psycojoker Psycojoker marked this pull request as ready for review January 17, 2025 05:21
Copy link

Failed to retrieve llama text: POST 500: 500: Unhandled error during initialisation

@Psycojoker Psycojoker force-pushed the lp-ruff branch 8 times, most recently from adc8548 to 18ce24b Compare February 5, 2025 18:15
@philogicae philogicae merged commit 78bc789 into master Feb 11, 2025
12 of 14 checks passed
@philogicae philogicae deleted the lp-ruff branch February 11, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants