fix: tolerate resolveId calls with win32-style importer path
#157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
changed the title
resolveId calls with win32-style importer path
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 5, 2024
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | vite-tsconfig-paths | 5.0.1 | 5.1.0 | ## [v5.1.0](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.0) - Add `skip` option for adding additional directories to be skipped when searching for tsconfig.json files ([#146](aleclarson/vite-tsconfig-paths#146)) - Fix path resolution on Windows when other Vite plugins neglect to normalize the `importer` path before calling `this.resolve` in their `resolveId` hooks ([#157](aleclarson/vite-tsconfig-paths#157)) - Allow both tsconfig.json and jsconfig.json in the same directory ([`4124b09`](aleclarson/vite-tsconfig-paths@4124b09))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 6, 2024
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | vite-tsconfig-paths | 5.0.1 | 5.1.0 | ## [v5.1.0](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.0) - Add `skip` option for adding additional directories to be skipped when searching for tsconfig.json files ([#146](aleclarson/vite-tsconfig-paths#146)) - Fix path resolution on Windows when other Vite plugins neglect to normalize the `importer` path before calling `this.resolve` in their `resolveId` hooks ([#157](aleclarson/vite-tsconfig-paths#157)) - Allow both tsconfig.json and jsconfig.json in the same directory ([`4124b09`](aleclarson/vite-tsconfig-paths@4124b09))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when
vite-tsconfig-pathswork with other plugins on windowsthe parameter
importerofresolveId hookcan be windows path and includes\charthat will cause
const resolvers = resolversByDir[projectDir]getundefinedit should fix some error like
Rollup failed to resolve importon windowshttps://github.com/aleclarson/vite-tsconfig-paths/issues?q=is%3Aissue+Rollup+failed+to+resolve+import
other detail see lisonge/vite-plugin-monkey#186 (comment)