Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skip option #146

Merged
merged 6 commits into from
Nov 4, 2024
Merged

feat: add skip option #146

merged 6 commits into from
Nov 4, 2024

Conversation

Akiyamka
Copy link
Contributor

@Akiyamka Akiyamka commented Jul 8, 2024

In monorepos it usefull to exclude big parts of repository that not related to vite
Resolves #147

Copy link
Owner

@aleclarson aleclarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Is there a reason you wouldn't want node_modules and .git directories to always be skipped even when skip is defined?
  2. The new option needs to be mentioned in the readme.

@Akiyamka
Copy link
Contributor Author

Is there a reason you wouldn't want node_modules and .git directories to always be skipped even when skip is defined?

I was thinking of this api as a way to override the default behavior as is common in builder configurations like webpack.
However, in my case I am completely satisfied with the option that this api only allows to expand this list without the possibility to remove .git, node_modules from it. 
If this option is better for you, I'll change the behavior. 

Sorry about readme, fixed

@aleclarson aleclarson changed the title add skip setting feat: add skip option Nov 4, 2024
@aleclarson aleclarson merged commit fe5937f into aleclarson:master Nov 4, 2024
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Nov 5, 2024
| datasource | package             | from  | to    |
| ---------- | ------------------- | ----- | ----- |
| npm        | vite-tsconfig-paths | 5.0.1 | 5.1.0 |


## [v5.1.0](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.0)

-   Add `skip` option for adding additional directories to be skipped when searching for tsconfig.json files ([#146](aleclarson/vite-tsconfig-paths#146))
-   Fix path resolution on Windows when other Vite plugins neglect to normalize the `importer` path before calling `this.resolve` in their `resolveId` hooks ([#157](aleclarson/vite-tsconfig-paths#157))
-   Allow both tsconfig.json and jsconfig.json in the same directory ([`4124b09`](aleclarson/vite-tsconfig-paths@4124b09))
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Nov 6, 2024
| datasource | package             | from  | to    |
| ---------- | ------------------- | ----- | ----- |
| npm        | vite-tsconfig-paths | 5.0.1 | 5.1.0 |


## [v5.1.0](https://github.com/aleclarson/vite-tsconfig-paths/releases/tag/v5.1.0)

-   Add `skip` option for adding additional directories to be skipped when searching for tsconfig.json files ([#146](aleclarson/vite-tsconfig-paths#146))
-   Fix path resolution on Windows when other Vite plugins neglect to normalize the `importer` path before calling `this.resolve` in their `resolveId` hooks ([#157](aleclarson/vite-tsconfig-paths#157))
-   Allow both tsconfig.json and jsconfig.json in the same directory ([`4124b09`](aleclarson/vite-tsconfig-paths@4124b09))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to skip some directories
2 participants