Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation and replace restored #3147

Conversation

daviscabral
Copy link
Collaborator

@daviscabral daviscabral commented Jul 26, 2018

@aksonov ended reverting what I was doing and simplifying by using the original react-navigation actions.

supremebeing7 and others added 3 commits July 22, 2018 16:31
…e-action

* react-navigation-v2:
  small tweaks
  bump version
  introduce onStateChange handler to be used instead of createReducer
  fix navTransparent
  add onEnter/onExit handlers and automatic transitions
  fix eslint
  fix error
  more eslint fixes
  fix eslint errors
  fix error
  fix eslint
  fix custom navigators
  Babel v7, ESlint fixes, React/React Navigation upgrades, mobx removed (aksonov#3142)
  use WIP RNRF for Example
  revert RN to 0.55.4
  upgrade Example to RN0.56
  WIP: migration to react-navigation v2.x (aksonov#3068)
@daviscabral daviscabral requested a review from aksonov July 26, 2018 10:22
Copy link
Owner

@aksonov aksonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK!

@aksonov
Copy link
Owner

aksonov commented Jul 26, 2018

Do you have any plans for POP_TO ?

@aksonov aksonov merged commit e8085cd into aksonov:react-navigation-v2 Jul 26, 2018
@daviscabral daviscabral deleted the dc/react-navigation-v2/replace-action branch July 26, 2018 10:26
@daviscabral
Copy link
Collaborator Author

Still checking about it - taking a look in the POP_TO_TOP to see if we could do something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants