Babel v7, ESlint fixes, React/React Navigation upgrades, mobx removed #3142
Conversation
* react-navigation-v2: use WIP RNRF for Example revert RN to 0.55.4 upgrade Example to RN0.56 WIP: migration to react-navigation v2.x (aksonov#3068)
|
@aksonov that's because I am using a local copy of |
|
I guess scenes.test.js should be disabled now because it works with internal state... |
|
@aksonov just fixed it - it was a problem with babel and jest. |
|
Cool - only linter errors now. |
|
Btw, what about removing |
|
Done - using src now 👍. |
| } | ||
|
|
||
| if (tabs) { | ||
| let createTabNavigator = createMaterialTopTabNavigator; |
There was a problem hiding this comment.
TabBarTop and TabBarBottom are deprecated.
|
I did already - but that limited a bit the way it can be customized. |
|
Yes, just found it. Don't worry, we will think about it later. |
|
Let me know when I can merge
… On 23 Jul 2018, at 10:49, Davis Z. Cabral ***@***.***> wrote:
I did already - but that limited a bit the way it can be customized.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Feel free to merge it - I got a few other things to keep going and I'll need to postpone the rest of changes for later tonight or tomorrow morning. |
|
No rush, will merge tomorrow then
… On 23 Jul 2018, at 22:31, Davis Z. Cabral ***@***.***> wrote:
Feel free to merge it - I got a few other things to keep going and I'll need to postpone the rest of changes for later tonight or tomorrow morning.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
daviscabral
changed the title
|
@aksonov initial work done. You will need to clone |
|
Well done, merging! |
…e-action * react-navigation-v2: small tweaks bump version introduce onStateChange handler to be used instead of createReducer fix navTransparent add onEnter/onExit handlers and automatic transitions fix eslint fix error more eslint fixes fix eslint errors fix error fix eslint fix custom navigators Babel v7, ESlint fixes, React/React Navigation upgrades, mobx removed (aksonov#3142) use WIP RNRF for Example revert RN to 0.55.4 upgrade Example to RN0.56 WIP: migration to react-navigation v2.x (aksonov#3068)
This PR is just to follow the changes I am doing - while airbnb/javascript repo is not fully on Babel v7 - I had to build it locally (I really hate monorepos for situations like this).