Allow developer to specify a tabBarOnPress function and set backToInitial to be true for tabs #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, could you also update docs and regenerate navigationStore again? |
|
Sorry for the delay, we were working hard on new version based on React Navigation 2.x, please check 4.0.0-beta.40 and if the bug exists, reapply this PR, thank you |
|
I've just committed the fix to work with react-navigation v2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #2932
Previously, if backToInitial was set, any function set in tabBarOnPress would not be called. In this commit, I checked if the developer specified a tabBarOnPress function and set backToInitial to be true; if so, we will run the code for backToInitial [ie. set tab child to initial Scene] and then call the user specified tabBarOnPress function.