<Tabs> backToInitial and tabBarOnPress interaction

[blah1234]

Version

• react-native-router-flux v4.0.0-beta.28
• react-native v0.53.0

Actual behaviour

I've found that if the "backToInitial" property is set for Tabs, then any function defined for the "tabBarOnPress" property is not called.

Expected behaviour

After browsing through the source code a bit, I see that "backToInitial" itself is implemented as a function set to "tabBarOnPress". I would have expected that any function users pass into the "tabBarOnPress" property be chained together with the "backToInitial" function if both "backToInitial" and "tabBarOnPress" are set for Tabs.

At the very least, the API documentation should notify users of the current behavior.

[aaron25mt]

Created a fix for this, will make a PR.
See my repo here if you need the fix ASAP.

[aksonov]

Please try to reproduce it with Example project and latest version 4.0.0-beta.40. Feel free to open if the issue still exists

[og24715]

@aksonov Still happen on v4.0.1 😡
Do you mean what this issue was solved on only beta40, but pending on v4.0.1? I was tried v4.0.1 and v4.0.2-dev. However, both not work for me.
You can try reproduce this issue by add tabBarOnPress with backToInitial in your Example project.

[daviscabral]

PR for better documentation to avoid this confusion for other users is welcome. But yeah, looking at the code I saw that if you define backToInitial - it's not possible to define tabBarOnPress - and keeping both handlers might be even worst (and harder to debug). I believe a warning would be fine - telling the user that the tabBarOnPress defined will be overwritten due the backToInitial flag defined.

[daviscabral]

I am pushing a PR with this change - I believe it does not hurt. :-)