Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple iOS URL types cause deep link parse to be crashed #2867

Closed
evianzhow opened this issue Feb 8, 2018 · 4 comments
Closed

Multiple iOS URL types cause deep link parse to be crashed #2867

evianzhow opened this issue Feb 8, 2018 · 4 comments

Comments

@evianzhow
Copy link
Contributor

Duplicated for #2787

Check this line:

const cleanUrl = this.props.uriPrefix ? url.split(this.props.uriPrefix)[1] : url;

"somePaymentMethod://callbackData".split("myApp://")[1] definitely return undefined, then passing to pathParser.

Crashed here:

const [urlCleaned] = url.split('?');

evianzhow added a commit to evianzhow/react-native-router-flux that referenced this issue Feb 8, 2018
@evianzhow
Copy link
Contributor Author

@m-vdb
Copy link

m-vdb commented Apr 23, 2018

Experiencing this as well. Having multiple URI schemes is not uncommon at all... @aksonov can you cherry-pick this commit evianzhow@685d015 in your repo? I guess you would want tests for that as well?

@aksonov
Copy link
Owner

aksonov commented Apr 23, 2018

@evianzhow Could you submit PR?

@evianzhow
Copy link
Contributor Author

@m-vdb @aksonov #3009

power1220 added a commit to power1220/react-native-router-flux that referenced this issue Apr 5, 2023
LuckyCoder5 added a commit to LuckyCoder5/react-native-router-flux that referenced this issue Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants