Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deep linking - error #2787

Closed
fonov opened this issue Jan 11, 2018 · 11 comments
Closed

deep linking - error #2787

fonov opened this issue Jan 11, 2018 · 11 comments

Comments

@fonov
Copy link

fonov commented Jan 11, 2018

Version

Tell us which versions you are using:
"react": "16.0.0",
"react-native": "0.51.0",
"react-native-router-flux": "4.0.0-beta.27"

Expected behaviour

Open scene

Actual behaviour

simulator screen shot - iphone 6 - 2018-01-11 at 12 45 17

@Blapi
Copy link
Collaborator

Blapi commented Jan 11, 2018

Show some code ???

@fonov
Copy link
Author

fonov commented Jan 11, 2018

<Provider store={store}>
                <RouterWithRedux uriPrefix={'google.ru'}>
                    <Lightbox>
                        <Scene key="root" hideNavBar hideTabBar>
                            <Scene key='Institution' component={Institution} path={"/institution/:id/"} />
                        </Scene>
                        <Scene key="SpinnerLightbox" component={SpinnerLightbox} />
                    </Lightbox>
                </RouterWithRedux>
            </Provider>

@Blapi
Copy link
Collaborator

Blapi commented Jan 11, 2018

What's the behaviour when you use Router instead of RouterWithRedux ?

@fonov
Copy link
Author

fonov commented Jan 11, 2018

const RouterWithRedux = connect()(Router);

@Blapi
Copy link
Collaborator

Blapi commented Jan 11, 2018

That was no what I was not meaning but anyway, can you have more logs about this bug? deep-linking is supposed to work so I'm not sure the issue is with the library

@aksonov
Copy link
Owner

aksonov commented Jan 11, 2018

@mounlion prefix is not correct at all, please check deep linking examples

@evianzhow
Copy link
Contributor

evianzhow commented Feb 8, 2018

@aksonov I've encountered this issue. Since @mounlion doesn't provide any useful information or its scenario, I tell mine.

My iOS app was registered with two URL schema, one called myApp:// and another called stripeOrAnythingElsePayment://, in App component, I registered myApp:// prefix and it handles all the routing logic in my own app, that's fine. But then coming to payment, my app jump out into third-party to finish its payment process. After success, third-party will call stripeOrAnythingElsePayment:// to return to my own App, and at that time, app crashed due to this issue.

Simple to reproduce, just create a project with two different URL schema and register App with one, then open another using xcrun simctl openurl booted "ANOTHER_URL://.

Hope it helps.

@evianzhow
Copy link
Contributor

@Blapi Please have a glimpse at what I've explained.

@Blapi
Copy link
Collaborator

Blapi commented Feb 10, 2018

@evianzhow I'm developing on Android and I'm using react-native-branch-deep-linking on my end, I'm sorry

@Blapi
Copy link
Collaborator

Blapi commented Aug 1, 2018

@evianzhow what's the status there?

@evianzhow
Copy link
Contributor

@Blapi Fixed in latest version

@Blapi Blapi closed this as completed Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants