Added InverseFishForMessage and nuget package fluent-assertions #5430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Dec 15, 2021
| @@ -11,6 +11,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <EmbeddedResource Include="Configs\TestScheduler.conf;Internal\Reference.conf" /> | |||
| <PackageReference Include="FluentAssertions" Version="5.10.3" /> | |||
There was a problem hiding this comment.
We should probably just take a dependency on FluentAssertions in the TestKit. I don't know why we haven't yet.
I'll make a bigger issue for this and we'll revisit that prior to releasing v1.4.30.
| @@ -56,6 +58,23 @@ public T FishForMessage<T>(Predicate<T> isMessage, TimeSpan? max = null, string | |||
| } | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Receives messages until <paramref name="max"/>. Ignores all messages except for a message of type <typeparamref name="T"/>. Asserts that all messages are not of the of type <typeparamref name="T"/>. Note that when comparing types, inheritance is ignored, in other words, only perfectly matching types are asserted. | |||
There was a problem hiding this comment.
Need to format this into a few separate lines.
| /// <typeparam name="T">The type that the message is not supposed to be.</typeparam> | ||
| /// <param name="probe"></param> | ||
| /// <param name="max"></param> | ||
| public async static Task InverseFishForMessage<T>(TestProbe probe, TimeSpan? max = null) |
There was a problem hiding this comment.
Should probably name this ReceiveUntil, FishUntil or something like that.
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Dec 15, 2021
Implement nitpicks from akkadotnet#5430
Aaronontheweb
added a commit
that referenced
this pull request
Dec 17, 2021
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Dec 20, 2021
* Make updates to `FishUntil` Implement nitpicks from akkadotnet#5430 * Nitpick * cleaned up `FishUntilMessage` * removed `FluentAssertions` reference * fixed bad `TestKit.ReceiveTests`
Aaronontheweb
added a commit
that referenced
this pull request
Dec 20, 2021
) * remove the forced waiting on the underlying transport to start up * racy spec fix: `BackoffOnRestartSupervisor_must_respect_maxNrOfRetries_property_of_OneForOneStrategy` (#5442) issue was that using `AutoReset` could cause a race where if the scheduler could reset the count in-flight and throw off the estimates used by the tests. Using a `ManualReset` avoids this issue. * deleted commented out code * Make updates to `FishUntil` (#5433) * Make updates to `FishUntil` Implement nitpicks from #5430 * Nitpick * cleaned up `FishUntilMessage` * removed `FluentAssertions` reference * fixed bad `TestKit.ReceiveTests` * Custom frame size computation support in Framing (#5444) * Custom frame size computation support in Framing * Speed up of framing spec * optimize `Props` `NewExpression` allocations (#5428) per #5416 (comment) Co-authored-by: Ismael Hamed <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is based on a thread I had with @Aaronontheweb on Gitter: https://gitter.im/akkadotnet/akka.net?at=61ae5b0acd3f06175df32eda.